Font smoothing background color is now a CSS property (Bug 1387594)

RESOLVED FIXED in Thunderbird 57.0

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: stefanh, Assigned: Paenglab)

Tracking

57 Branch
Thunderbird 57.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

a year ago
In order to get the right font smoothing background color in vibrant areas you need to use the CSS property "-moz-font-smoothing-background-color". I haven't checked, but it's probably just the source lists that needs it.
(Assignee)

Comment 1

a year ago
Thank you, Stefan. I have already a patch and I hope you aren't on creating one.
(Assignee)

Comment 2

a year ago
Created attachment 8909016 [details] [diff] [review]
fontSmoothing.patch

Unfortunately we have no Mac reviewer. So please could you review it?
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8909016 - Flags: review?(stefanh)
(Reporter)

Comment 3

a year ago
Comment on attachment 8909016 [details] [diff] [review]
fontSmoothing.patch

Review of attachment 8909016 [details] [diff] [review]:
-----------------------------------------------------------------

I'm usually called stefanh (commit msg) ;-)

In messengercompose.css there’s one occurrence of ’-moz-appearance: menupopup;’ and one occurrence of ’-moz-appearance: menuitem;’, but I assume the toolkit files takes care of that. But then the -moz-appearance rules could be removed from messengercompose.css (there's no -moz-font-smoothing-background-color rule for https://dxr.mozilla.org/comm-central/rev/bda524beac249b64aa36016800502a34073bf35a/mozilla/toolkit/themes/osx/global/menu.css#10 and I've asked mstange about that). 

You might want to fix im/themes/conversation.css as well (there's one 'moz-mac-source-list' rule there).
Attachment #8909016 - Flags: review?(stefanh) → review+
(Assignee)

Comment 4

a year ago
Created attachment 8909035 [details] [diff] [review]
fontSmoothing.patch

Thanks

(In reply to Stefan [:stefanh] from comment #3)
> Comment on attachment 8909016 [details] [diff] [review]
> fontSmoothing.patch
> 
> Review of attachment 8909016 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I'm usually called stefanh (commit msg) ;-)

Sorry, fixed.

> In messengercompose.css there’s one occurrence of ’-moz-appearance:
> menupopup;’ and one occurrence of ’-moz-appearance: menuitem;’, but I assume
> the toolkit files takes care of that. But then the -moz-appearance rules
> could be removed from messengercompose.css (there's no
> -moz-font-smoothing-background-color rule for
> https://dxr.mozilla.org/comm-central/rev/
> bda524beac249b64aa36016800502a34073bf35a/mozilla/toolkit/themes/osx/global/
> menu.css#10 and I've asked mstange about that). 

I checked it and the toolkit rules for font-smoothing are active. The -moz-appearance rules are needed because toolkit sets them to 'none' with the menulist[editable="true"] > ... rule and I want the normal menupopup appearance.

> You might want to fix im/themes/conversation.css as well (there's one
> 'moz-mac-source-list' rule there).

This is for IB and I don't build it for checking if it is working correctly.
Attachment #8909016 - Attachment is obsolete: true
Attachment #8909035 - Flags: review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 5

a year ago
Shouldn't we add it to im/themes/conversation.css anyway? We usually keep IB going with all the other ports we do if they're easy.
(Assignee)

Comment 6

a year ago
Created attachment 8909046 [details] [diff] [review]
fontSmoothing.patch

Okay, I'm convinced. Added the IB file.
Attachment #8909035 - Attachment is obsolete: true
Attachment #8909046 - Flags: review+

Comment 7

a year ago
https://hg.mozilla.org/comm-central/rev/937beb54bc99a4ebce47bf01d2aaebee9d6636e0
Font smoothing background color is now a CSS property (Bug 1387594). r=stefanh

In the last patch the "h" was missing from the reviewer's name, but nothing escapes the good sheriff ;-)
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.