Closed Bug 1400584 Opened 2 years ago Closed 2 years ago

Port bug 1399499 to TB [Add additional margin-top to the tabs toolbar on Windows 7 per Photon spec]

Categories

(Thunderbird :: Theme, enhancement)

All
Windows 7
enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

From bug 1399499: The margin on the window should be consistent on all sides:

http://design.firefox.com/people/shorlander/photon/Mockups/windows-7.html
Attached patch win7TopMargin.patch (obsolete) — Splinter Review
The FX change: https://hg.mozilla.org/integration/autoland/rev/134474e7c8a9

I'm using 6px because then the top margin is the same as the side border. I also add the margin only to Aero and Basic. Classic and HC-themes have already the top border.

The selector is also different because on Aero we show the menu bar below the tabs.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8909019 - Flags: review?(jorgk)
Patch wasn't updated. Now the correct one.
Attachment #8909019 - Attachment is obsolete: true
Attachment #8909019 - Flags: review?(jorgk)
Attachment #8909021 - Flags: review?(jorgk)
Comment on attachment 8909021 [details] [diff] [review]
win7TopMargin.patch

I don't have Windows 7 right now, so I need to trust you on this.
Attachment #8909021 - Flags: review?(jorgk) → review+
Maybe you can make a late check when you are back in Berlin? But it needs drawintitlebar enabled.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/d8edabf2a836
Port bug 1399499 to TB [Add additional margin-top to the tabs toolbar on Windows 7 per Photon spec]. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.