1400614 - Crash with media devtools if no video track present

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Jean-Yves Avenard [:jya]]

https://crash-stats.mozilla.com/report/index/e8fd3536-fa1f-4aab-a5e5-029ce0170916
https://crash-stats.mozilla.com/report/index/d0cb5620-ae80-4a66-be80-3631a0170916

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1400614 - P1. Handle case where we have no video track.

Review commit: https://reviewboard.mozilla.org/r/180648/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180648/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8909052 [details]
Bug 1400614 - P1. Handle case where we have no video track.

https://reviewboard.mozilla.org/r/180648/#review185746

Thank you for fixing this.

::: dom/media/MediaFormatReader.cpp:3175
(Diff revision 1)
> +                        : mVideo.mOriginalInfo
> +                          ? *mVideo.mOriginalInfo->GetAsVideoInfo()
> +                          : VideoInfo();
>  
>    result += nsPrintfCString(
> -    "Video Decoder(%s, %dx%d @ %0.2ffps): %s\n",
> +    "Video Decoder(%s, %dx%d @ %0.2f): %s\n",

Why this unrelated change?

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8909052 [details]
Bug 1400614 - P1. Handle case where we have no video track.

https://reviewboard.mozilla.org/r/180648/#review185746

> Why this unrelated change?

because it looks ugly after all... amd making a separate patch didnt seem worth it

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: Bug 1400614 - P2. Change string output content.

Doesn't look as nice as I had hoped.

Review commit: https://reviewboard.mozilla.org/r/180680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180680/

Comment 5

[Jean-Yves Avenard [:jya]]

Comment on attachment 8909052 [details]
Bug 1400614 - P1. Handle case where we have no video track.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180648/diff/1-2/

Comment 6

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8909083 [details]
Bug 1400614 - P2. Change string output content.

https://reviewboard.mozilla.org/r/180680/#review185750

Thank you!

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/92224fd4468a
https://hg.mozilla.org/mozilla-central/rev/0806dedfeae9