Closed
Bug 140063
Opened 23 years ago
Closed 23 years ago
Publish icon doesn't become active when changes are made under <HTML> source tab.
Categories
(SeaMonkey :: Composer, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla1.0.1
People
(Reporter: TucsonTester1, Assigned: cmanske)
References
Details
(Whiteboard: publish [adt2 rtm][fixed in branch],custrtm-)
Attachments
(1 file, 1 obsolete file)
|
857 bytes,
patch
|
akkzilla
:
review+
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.0rc1)
Gecko/20020423 Netscape6/6.2.1+
BuildID: 2002042306
When editing a page in the <HTML> source mode in Composer the Publish icon does
not become "active" when changes are made.
Reproducible: Always
Steps to Reproduce:
1.Open new/blank Composer window.
2.Enter content to the page in Normal mode.
3.Click file|publish as... and publish page to valid site.
4.Notice the Publish icon now appears on the toolbar (grayed out).
5.Enter more content in Normal mode.
6.Notice Publish icon becomes "active" when page is changed.
7.Click Publish icon to publish page....icon grays out.
8.Click <HTML> source tab.
9.Enter content or edit page.
Actual Results: The Publish icon does not become active when changes are made
in the <HTML> source mode. Also, if file menu is accessed, the publish option
is grayed out.
Expected Results: The Publish icon becomes "active" when the page is edited in
any mode.
The page can be published by either selecting "publish as.." from the file menu
(which is still active) or clicking on any of the other view tabs (Normal,
Preview, Show all tags. When any of the other views is opened the publish icon
becomes "active" and will remain active even if <HTML> source view is opened again.
|
Assignee | |
Comment 1•23 years ago
|
||
Simple fix: Make Publish command act like Save command.
|
|
Assignee | |
Comment 2•23 years ago
|
||
This is an important usability fix -- user must be able to resave (in this case,
publish) any change to document. The "Save" command does this when editing
local files. We must do the same with "Publish" command when editing remote files.
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Keywords: nsbeta1
Whiteboard: publish[adt2]
Target Milestone: --- → mozilla1.0
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: publish[adt2] → publish[adt2][FIX IN HAND][need r=,sr=]
|
||
Comment 3•23 years ago
|
||
In the first part of the patch, it seems like you're adding a
window.gHTMLSourceChanged when there's already window.gHTMLSourceChanged in the
first line of that return statement ... or am I reading that wrong? Is this
added line really changing anything?
|
|
Assignee | |
Comment 4•23 years ago
|
||
Doh! Akkana's right, the ComposerCommands.js change wasn't needed.
We already paid attention to the source window changes.
Attachment #81054 -
Attachment is obsolete: true
|
|
||
Comment 5•23 years ago
|
||
Comment on attachment 81163 [details] [diff] [review]
patch v2.
r=akkana
Attachment #81163 -
Flags: review+
|
|
Assignee | |
Updated•23 years ago
|
Whiteboard: publish[adt2][FIX IN HAND][need r=,sr=] → publish[adt2][FIX IN HAND][need sr=]
Attachment #81163 -
Flags: superreview+
Whiteboard: publish[adt2][FIX IN HAND][need sr=] → publish[adt2][FIX IN HAND][reviewed]
|
|
Assignee | |
Comment 7•23 years ago
|
||
checked into trunk
|
||
Comment 9•23 years ago
|
||
adt1.0.0+ (on ADT's behalf) for approval to checkin to the 1.0 branch, pending
Drivers approval. After, checking in, please add the fixed1.0 keyword.
Whiteboard: publish [adt2 rtm] [Needs a=] → publish [adt2 rtm] [Needs a=],custrtm-
|
|
Assignee | |
Updated•23 years ago
|
Keywords: mozilla1.0.1
|
|
Assignee | |
Updated•23 years ago
|
|
||
Comment 10•23 years ago
|
||
a=chofmann for 1.0.1
|
|
Assignee | |
Updated•23 years ago
|
Keywords: mozilla1.0.1 → mozilla1.0.1+
Whiteboard: publish [adt2 rtm] [Needs a=],custrtm- → publish [adt2 rtm]approved,custrtm-
|
|
Assignee | |
Comment 11•23 years ago
|
||
checked into mozilla1.0.1 branch
Keywords: mozilla1.0.1+ → fixed1.0.1
Whiteboard: publish [adt2 rtm]approved,custrtm- → publish [adt2 rtm][fixed in branch],custrtm-
Keywords: fixed1.0.1
|
||
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•