1400644 - Container tab menu icons seem to close to labels

Status: RESOLVED WORKSFORME

(Firefox :: Menus, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

See screenshot. This is a recent regression. I bisected it to bug 1388167.

[Tracking Requested - why for this release]:

Visual glitch that seems unfortunate, especially given our recent blog posts about container tabs[1].

[1]: https://blog.mozilla.org/firefox/introducing-firefox-multi-account-containers/

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screenshot

Comment 2

[Johann Hofmann [:johannh]]

Erica, would you like to fix this one? :)

I disagree that this should track 57, it's a minor visual glitch in a feature that can only be turned on using an add-on. We _might_ fix it for uplift to 57, but we can definitely ship 57 without the fix (and there are much higher priority blockers for 57 that we should focus on).

Comment 3

[Jonathan Kingston [:jkt] he/him]

This menu isn't related the the extension mentioned in [1]. I'm actually thinking we should remove this menu now that we have the longpress on the + button and a conflicting Firefox supported extension (people are constantly confused by this, in reality this icon should have been updated with the contents of the extension however we didn't get approval to ship as a system addon to start with).
I'm not sure if this same issue impacts other menus though as I don't think it's anything different in implementation.

Comment 4

[Johann Hofmann [:johannh]]

(In reply to Jonathan Kingston [:jkt] from comment #3)
> This menu isn't related the the extension mentioned in [1]. I'm actually
> thinking we should remove this menu now that we have the longpress on the +
> button and a conflicting Firefox supported extension).

I agree, less stuff to maintain. Can you file a bug, please? :)

Comment 5

[Jonathan Kingston [:jkt] he/him]

Bug 1400812 to track.

Comment 6

[Erica Wright [:ewright]]

I can take it :johannh

Comment 7

[Johann Hofmann [:johannh]]

Actually, I think this has been fixed by bug 1400810. The entire panel still looks a bit off but I think the best fix for that is bug 1400812.

Comment 8

[Johann Hofmann [:johannh]]

Ok, uh, let's close as WORKSFORME and track removal in bug 1400812.

Comment 9

[Jonathan Kingston [:jkt] he/him]

WFM too, the spacing of icons look a little too wide on touch compared to height but I suspect that is the same for all context menus.