1400651 - Capitalize "upcoming" (section) in Calendar prefs

Status: RESOLVED FIXED

(Calendar :: Preferences, enhancement)

Description

[Ton [:Tonnes]]

Attachment: upcoming_Upcoming.patch

In the Preferences/Options > Calendar panel > General tab, current Calendar/Lightning contains a string/option that says

"The upcoming section shows:"(pref.soondays.label)

This is about the section called Upcoming in the right pane.

It would be good to capitalize "Upcoming", as if not, this would refer to a section that’s upcoming, rather than a section _called_ Upcoming. It also seems to have lead to some wrong localizations (to the first form) for a few locales.

Side note: I wouldn’t mind if quotation marks were added too ("The “Upcoming” section shows:"), though that seems rather divergent in TB/Lightning strings.

Comment 1

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8909086 [details] [diff] [review]
upcoming_Upcoming.patch

Review of attachment 8909086 [details] [diff] [review]:
-----------------------------------------------------------------

Since this is only a correction of the English I think we could get away with not changing the entity, but if there is more than 1-2 cases we could go with it. Do you have examples of locales that translated it wrong? r+ with changes accordingly.

Comment 2

[Ton [:Tonnes]]

I agree with not changing the entity, as long as localizers get notified e.g. by a mailing list or newsgroup notification. The entity change was proposed to make sure they will otherwise, but it’s your choice. :)

The next view displays the string for all locales. Of course I don’t speak all of them, but it may be obvious some did not notice the issue (I would say at least 10, such as bg, cs, cy, en-GB, es-AR, et, eu, fy-NL, gl, pt-*, …):

https://transvision.mozfr.org/string/?entity=calendar/chrome/calendar/preferences/general.dtd:pref.soondays.label&repo=central

Comment 3

[Jorg K (CEST = GMT+2)]

If you change the ID for "educational purposes", please add a comment stating that "Upcoming" is the name of a section and should be shown as that in the translation. For example:
<!-- LOCALIZATION NOTE (pref.soondays2.label):
     "Upcoming" is the name of a section and the translation must match the translation of that
     section name. Also, it should be upper case (as a proper name) if the target language permits.
 -->

The link in comment #2 is quite interesting, for example:
es-ES 	La sección Próximamente muestra: (correct)
es-AR 	La próxima sección muestra: (incorrect).

Comment 4

[Ton [:Tonnes]]

Attachment: upcoming_Upcoming_v2.patch

OK, added the suggested comment including the entity referred to.

Comment 5

[Jorg K (CEST = GMT+2)]

Comment on attachment 8920810 [details] [diff] [review]
upcoming_Upcoming_v2.patch

Looks great, I hope Philipp agrees.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8920810 [details] [diff] [review]
upcoming_Upcoming_v2.patch

r=philipp

Comment 7

[Jorg K (CEST = GMT+2)]

I'll get that landed and I'll fix the commit message.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/773c0fd4b623
Rename upcoming to Upcoming (section) in prefs. r=philipp