Closed Bug 1400660 Opened 3 years ago Closed 2 years ago

Create a new pref to determine the initial state of the "See details" panel in about:blocked pages

Categories

(Firefox :: Security, defect, P3)

defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox58 --- verified

People

(Reporter: prathiksha, Assigned: prathiksha)

References

Details

Attachments

(2 files)

Create a new pref to determine the initial state (show on load/ hide on load) of the "See details" panel in about:blocked pages.
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Component: General → Security
Depends on: 1363051
Flags: qe-verify-
Priority: -- → P3
Comment on attachment 8922954 [details]
Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

https://reviewboard.mozilla.org/r/194126/#review199160

Looks good to me, but Johann should make sure it's also fine from a front-end point of view.
Attachment #8922954 - Flags: review?(francois) → review+
Comment on attachment 8922954 [details]
Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

https://reviewboard.mozilla.org/r/194126/#review199162
Attachment #8922954 - Flags: review?(jhofmann)
Attachment #8922954 - Flags: review?(jhofmann) → review?(dao+bmo)
Attachment #8922954 - Flags: review?(dao+bmo) → review?(jhofmann)
Comment on attachment 8922954 [details]
Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

https://reviewboard.mozilla.org/r/194126/#review201342

Seems good to me, I'm not sure if I would have rather put this pref under browser.safebrowsing, but I guess either way is fine.

::: browser/base/content/content.js:203
(Diff revision 1)
>      // Set the firefox support url.
>      doc.getElementById("firefox_support").setAttribute("href",
>        "https://support.mozilla.org/kb/how-does-phishing-and-malware-protection-work");
>  
> +    // Show safe browsing details on load if the pref is set to true.
> +    let show = Services.prefs.getBoolPref("browser.xul.error_pages.show_safe_browsing_details_on_load");

Nit: maybe this variable could be named a little more clearly, such as showDetails?
Attachment #8922954 - Flags: review?(jhofmann) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f1f109730a9b
Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages. r=francois,johannh
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f1f109730a9b
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
I can see this pref implemented in latest nightly 58.0a1 in Linux-x86_64

Build ID 	20171109100107
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
QA Whiteboard: [bugday-20171108]
This bug was about "Creating a new pref to determine the initial state of the "See details" panel in about:blocked pages" and I have seen the feature being implemented worth latest Nightly!

Build ID 	20171108110838
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171108]
As this bug is verified in both linux(comment 8) and windows (comment 9), I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.