1400660 - Create a new pref to determine the initial state of the "See details" panel in about:blocked pages

Status: VERIFIED FIXED

(Firefox :: Security, defect, P3)

Description

[:prathiksha]

Attachment: Screen Shot 2017-09-17 at 4.15.09 PM.png

Create a new pref to determine the initial state (show on load/ hide on load) of the "See details" panel in about:blocked pages.

Comment 1

[:prathiksha]

Attachment: Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

Review commit: https://reviewboard.mozilla.org/r/194126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/194126/

Comment 2

[François Marier [:francois]]

Comment on attachment 8922954 [details]
Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

https://reviewboard.mozilla.org/r/194126/#review199160

Looks good to me, but Johann should make sure it's also fine from a front-end point of view.

Comment 3

[François Marier [:francois]]

Comment on attachment 8922954 [details]
Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

https://reviewboard.mozilla.org/r/194126/#review199162

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8922954 [details]
Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

https://reviewboard.mozilla.org/r/194126/#review201342

Seems good to me, I'm not sure if I would have rather put this pref under browser.safebrowsing, but I guess either way is fine.

::: browser/base/content/content.js:203
(Diff revision 1)
>      // Set the firefox support url.
>      doc.getElementById("firefox_support").setAttribute("href",
>        "https://support.mozilla.org/kb/how-does-phishing-and-malware-protection-work");
>  
> +    // Show safe browsing details on load if the pref is set to true.
> +    let show = Services.prefs.getBoolPref("browser.xul.error_pages.show_safe_browsing_details_on_load");

Nit: maybe this variable could be named a little more clearly, such as showDetails?

Comment 5

[:prathiksha]

Comment on attachment 8922954 [details]
Bug 1400660 - Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/194126/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1f109730a9b
Create a new pref to determine the initial state of the 'See details' panel in about:blocked pages. r=francois,johannh

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f1f109730a9b

Comment 8

[Sayed [:LiquidO2]]

I can see this pref implemented in latest nightly 58.0a1 in Linux-x86_64

Build ID 	20171109100107
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0

Comment 9

[Mohammad Maruf Rahman]

This bug was about "Creating a new pref to determine the initial state of the "See details" panel in about:blocked pages" and I have seen the feature being implemented worth latest Nightly!

Build ID 	20171108110838
User Agent 	Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171108]

Comment 10

[Sayed [:LiquidO2]]

As this bug is verified in both linux(comment 8) and windows (comment 9), I am marking this bug as verified fixed.