1400675 - JavaScript strict warning: resource://gre/modules/TelemetryReportingPolicy.jsm, line 433: ReferenceError: reference to undefined property "FirsRunURL"

Status: VERIFIED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Tobias (:Tobbi) Markus]

I am trying to write a Firefox extension and noticed the following in the console:
JavaScript strict warning: resource://gre/modules/TelemetryReportingPolicy.jsm, line 433: ReferenceError: reference to undefined property "FirsRunURL"

This seems to be a typo. I will fix it, as soon as I find out how this review process works.

Comment 1

[Tobias (:Tobbi) Markus]

Attachment: Bug 1400675 - Fix reference to undefined property FirsRunURL

Review commit: https://reviewboard.mozilla.org/r/180836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180836/

Comment 2

[Georg Fritzsche [:gfritzsche]]

Comment on attachment 8909238 [details]
Bug 1400675 - Fix reference to undefined property FirsRunURL

https://reviewboard.mozilla.org/r/180836/#review186010

Thanks for the catch!

Comment 3

[Georg Fritzsche [:gfritzsche]]

This was introduced in 56:
https://hg.mozilla.org/mozilla-central/rev/a86a44628486#l1.192

The affect will be:
- we can't use the background data policy tab (due to the typo)
- we fall back to the old data policy implementation

Comment 4

[Georg Fritzsche [:gfritzsche]]

Dao, does that sound right to you?
Do you know from which release on we're using the background policy tab?

Comment 5

[Georg Fritzsche [:gfritzsche]]

[Tracking Requested - why for this release]:
This prevents us from using the new background privacy policy tab.
We have a fallback to the old policy bar, so it's not very critical.

Comment 6

[Dão Gottwald [:dao]]

(In reply to Georg Fritzsche [:gfritzsche] [away Sep 19 - Oct 3] from comment #4)
> Dao, does that sound right to you?

Yep.

> Do you know from which release on we're using the background policy tab?

Firefox 55 as far as I know (bug 1367076).

Comment 7

[Chris H-C :chutten]

ni?pdol,canuckistani for a more product perspective of how bad it would be for us to, in 55, show the background tab and then, in 56, to go back to showing the infobar.

How hard do we want to push this for 56? Did this not get added to the 56 testplan?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/84bc19f5cbe5
Fix reference to undefined property FirsRunURL r=gfritzsche

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/84bc19f5cbe5

Comment 10

[Jeff Griffiths (:canuckistani) (:⚡︎)]

While I don't think this is dot-release-worthy, it's probably worth uplifting and riding along a potential 56 dot release. It seems low risk.

Comment 11

[Chris H-C :chutten]

Comment on attachment 8909238 [details]
Bug 1400675 - Fix reference to undefined property FirsRunURL

Approval Request Comment
[Feature/Bug causing the regression]: Telemetry First Run Data Collection Notice
[User impact if declined]: We show the data collection infobar instead of the background tab
[Is this code covered by automated tests?]: Nope
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]:  Please do. Start a fresh Beta profile and ensure that the Data Policy tab instead of the "Choose what I share" infobar
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: Not really, no.
[Why is the change risky/not risky?]: It's a typo, and we already have a fallback for if it doesn't work.
[String changes made/needed]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8909238 [details]
Bug 1400675 - Fix reference to undefined property FirsRunURL

56 is on release now.

Comment 13

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8909238 [details]
Bug 1400675 - Fix reference to undefined property FirsRunURL

Typo fix - this should be fine to uplift for 56 RC2.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/3a9530f00c6e

Comment 15

[Chris H-C :chutten]

Florin, do we have testing for first-run situations? bug 1367076 introduced a background tab opening with our privacy notice instead of the "Choose What I Share" infobar. We regressed the behaviour in 56, showing the infobar instead.

Comment 16

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

(In reply to Chris H-C :chutten from comment #15)
> Florin, do we have testing for first-run situations? bug 1367076 introduced
> a background tab opening with our privacy notice instead of the "Choose What
> I Share" infobar. We regressed the behaviour in 56, showing the infobar
> instead.

We don't have any dedicated test cases for first-run, mainly because it's constantly changing. However we can verify that this works correctly in 56 RC2 once it's available. Moving to Andrei for tracking.

Comment 17

[Ciprian Georgiu, Desktop QA]

Reproduced this issue using the STR from comment 11 on an affected Nightly build 57.0a1 (2017-09-17).

Verified fixed on 56.0 RC3 (2017092123461) and 57.0b2 (20170921191414) across platforms:
- Windows 10 x64
- Mac OS X 10.11.6
- Ubuntu 16.04 x64

The Data Policy page is properly loaded in the background tab - https://www.mozilla.org/en-US/privacy/firefox/ on a fresh profile, instead of the "Choose What I Share" infobar.