1400693 - PhabFactory should automatically associate a user with a revision

Status: RESOLVED WONTFIX

(Conduit :: Lando, enhancement)

Description

[Māris Fogels [:mars] (please needinfo)]

The PhabFactory object should automatically associate a user with a revision when creating a new revision.

The suite has poor quality test code like this:

def mytest:
  phabfactory.user()
  phabfactory.revision()


This would be better:

def mytest:
  phabfactory.revision() # user/author is created and associated automatically


If you need to customize the author:

def mytest:
  foo_user = phabfactory.user(name='Foo')
  phabfactory.revision(author=foo_user)

Comment 1

[Israel Madueme [:imadueme]]

Part of this is completed in https://bugzilla.mozilla.org/show_bug.cgi?id=1399219. Missing is accepting an `author` parameter in `phabfactory.revision()`.

Comment 2

[Mark Côté [:mcote]]

Has this since been implemented?  If not, how does it fit into our stories (the summary is too low-level for me to be sure).

Comment 3

[Israel Madueme [:imadueme]]

The goal of this bug (to be able to create a mock revision that points to a mock author) has been implemented. You must pass a author_phid (of an author that already has been mocked) to the revision factory. mars' suggestion to be able to pass it directly to the factory is 100% the way to go, though. That said, I do not believe this is critical at this time so this bug can be closed imo.

Comment 4

[Mark Côté [:mcote]]

It sounds like you're saying this is an improvement we might want some day, so I'll leave it open but move it to the backlog (and unassign it).

Comment 5

[Steven MacLeod [:smacleod]]

phabfactory no longer exists.