1400705 - cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings)

Status: RESOLVED FIXED

(Core :: Graphics, defect, P5)

Description

[Chris Peterson [:cpeterson]]

warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option]

gfx/cairo/cairo/src/cairo-quartz-surface.c:1908:6: warning: code will never be executed [-Wunreachable-code]

gfx/cairo/libpixman/src/pixman-bits-image.c:268:32: warning: shifting a negative signed value is undefined [-Wshift-negative-value]

Comment 1

[Chris Peterson [:cpeterson]]

Attachment: Bug 1400705 - cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings).

* The -Wno-unused-but-set-variable flag is supported by gcc but not clang, so move it to a gcc-only CFLAGS.

* The -Wno-error=uninitialized flag is supported by both gcc and clang, so move it to CFLAGS shared by gcc and clang.

* Also suppress -Wunreachable-code and -Wshift-negative-value clang warnings. gcc supports -Wshift-negative-value, but only starting in gcc 6.1 and we are still using gcc 4.9 in automation.

warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option]
gfx/cairo/cairo/src/cairo-quartz-surface.c:1908:6: warning: code will never be executed [-Wunreachable-code]
gfx/cairo/libpixman/src/pixman-bits-image.c:268:32: warning: shifting a negative signed value is undefined [-Wshift-negative-value]

Review commit: https://reviewboard.mozilla.org/r/180718/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180718/

Comment 2

[Lee Salzman [:lsalzman]]

Comment on attachment 8909144 [details]
Bug 1400705 - cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings).

https://reviewboard.mozilla.org/r/180718/#review185770

Comment 3

[Chris Peterson [:cpeterson]]

Wow! Thanks for the lightning fast review. :)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4dad276a523
cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings). r=lsalzman

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e4dad276a523