cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings)

RESOLVED FIXED in Firefox 57

Status

()

defect
P5
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox55 unaffected, firefox56 unaffected, firefox57 fixed)

Details

Attachments

(1 attachment)

warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean '-Wno-unused-const-variable'? [-Wunknown-warning-option]

gfx/cairo/cairo/src/cairo-quartz-surface.c:1908:6: warning: code will never be executed [-Wunreachable-code]

gfx/cairo/libpixman/src/pixman-bits-image.c:268:32: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
Comment on attachment 8909144 [details]
Bug 1400705 - cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings).

https://reviewboard.mozilla.org/r/180718/#review185770
Attachment #8909144 - Flags: review?(lsalzman) → review+
Wow! Thanks for the lightning fast review. :)
Priority: -- → P5
Version: 51 Branch → Trunk
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e4dad276a523
cairo: Fix -Wunknown-warning-option clang warning about gcc flag (and suppress some other warnings). r=lsalzman
https://hg.mozilla.org/mozilla-central/rev/e4dad276a523
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.