Closed Bug 1400746 Opened 2 years ago Closed 2 years ago

checksums failure when boto3 and botocore present in our pypi mirrors

Categories

(Release Engineering :: Release Automation: Other, enhancement, P1)

enhancement

Tracking

(firefox-esr52 fixed, firefox56 fixed, firefox57 fixed)

RESOLVED FIXED
Tracking Status
firefox-esr52 --- fixed
firefox56 --- fixed
firefox57 --- fixed

People

(Reporter: nthomas, Assigned: nthomas)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1361930 added boto3 and botocore to our mirrors, then the checksums task in the release automation makes some bad life choices:
  Using version 3-1.4.7 (newest of versions: 3-1.4.7, 3-1.4.7, 2.38.0, 2.38.0, 2.32.1, 2.32.1, 2.17.0, 2.17.0, core-1.7.7, core-1.7.7)

Notice it's just trimming the leading 'boto' off boto3-1.4.7 and botocore-1.7.7, and ends up installing boto3. This was fixed in pip 1.2 via https://github.com/pypa/pip/issues/510, but we're still on 1.1 because this is a job which runs via bbb on a linux host, and /tools/python27-virtualenv/lib/python2.7/site-packages/virtualenv_support/pip-1.1.tar.gz. Hrmph!
mozharness is using pypi.{pub,pvt}.build.mozilla.org when it create the virtualenv and we have the slightly less ancient 1.5.5 there, so this change is enough to install the correct boto. Could be explicit about the version if that would be more defensive, given recent pip upgrade issues.
Attachment #8909160 - Flags: review?(catlee)
Pushed by nthomas@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f8c3e7d5f10d
checksums failure when boto3 and botocore present in our pypi mirrors, r=catlee DONTBUILD
https://hg.mozilla.org/mozilla-central/rev/f8c3e7d5f10d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
(In reply to Nick Thomas [:nthomas] from comment #3)
> https://hg.mozilla.org/releases/mozilla-beta/rev/
> 6b5cce5da78594813192d46f129b6e5a012c9650

Can we please avoid double-landing patches on inbound/beta until after the version bump to 58? We're syncing m-c and m-b anyway and the more things that get landed straight to Beta, the higher risk of having to rely on hg's merge resolutions to do the right thing.
Flags: needinfo?(nthomas)
Sorry about that, old habits.
Flags: needinfo?(nthomas)
Blocks: 1405177
We could probably back this out now that we have pip 8.1.2 in tree via bug 1297515.
You need to log in before you can comment on or make changes to this bug.