1400751 - Bookmark star and Pocket animations are misaligned in touch mode

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Jonathan Kingston [:jkt] he/him]

Attachment: bookmark-icon.PNG

Bookmarking a page aligns the item wrong in the lastest nightly.
See attached.

Comment 1

[:Gijs (he/him)]

Is this with compact density, or normal or touch, and always or for some pages or when the window is small, or only mid-animation, or only with the light/dark theme or something? Does it also happen when the page isn't bookmarked?

(I can't reproduce after trying several configurations)

Comment 2

[:Gijs (he/him)]

Also, what dpi setting are you using in Windows? And is this a regression, and if so, any chance you can find a regression window?

Comment 3

[Johann Hofmann [:johannh]]

Also, does it happen without the container label in the urlbar?

Comment 4

[Jonathan Kingston [:jkt] he/him]

Touch density in Windows. Containers doesn't make a difference. This happens through the whole animation and finishes like that.
Soon as I click the icon it moves, the default position is correct.

I'm using 150% scaling within windows itself on a 42" inch 4k monitor on 3840x2160 res.

I haven't modified the default dpi in about:config.

Comment 5

[Jonathan Kingston [:jkt] he/him]

It also replicates on my 4k screen for the laptop too, the scaling appears to be set to the same though which perhaps might be the issue?

Comment 6

[Jonathan Kingston [:jkt] he/him]

At 100% scaling the issue seems to be the same too.

Comment 7

[:Gijs (he/him)]

Looks like this regressed around the time of bug 1397583. I can only reproduce in touch mode. Jonathan, does that match what you're seeing?

Comment 8

[Jonathan Kingston [:jkt] he/him]

Confirm, it looks like a regression and I can only reproduce with touch mode.

Comment 9

[Drew Willcoxon :adw]

I see it too.  I must have screwed up the touch part of bug 1397583.

Comment 10

[Drew Willcoxon :adw]

Yikes, I copy-pasted a selector from the star button CSS into Pocket's CSS but didn't actually update it after that.  Which means that not only is the animated star button wrong in touch mode, the animated Pocket button is, too.

Comment 11

[Drew Willcoxon :adw]

Attachment: Bug 1400751 - Bookmark star and Pocket animations are misaligned in touch mode.

Review commit: https://reviewboard.mozilla.org/r/180942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180942/

Comment 12

[Drew Willcoxon :adw]

OK, I tested this with both the star and Pocket buttons on all three densities on Windows, and on both densities on macOS.

Comment 13

[:Gijs (he/him)]

Comment on attachment 8909435 [details]
Bug 1400751 - Bookmark star and Pocket animations are misaligned in touch mode.

https://reviewboard.mozilla.org/r/180942/#review186132

Comment 14

[Drew Willcoxon :adw]

https://hg.mozilla.org/integration/autoland/rev/ff7917ed161f

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ff7917ed161f