Closed Bug 1400815 Opened 2 years ago Closed 2 years ago

[ja] Unexpected English string remains in /browser/preferences/privacy.dtd

Categories

(Mozilla Localizations :: ja / Japanese, defect, critical)

All
Unspecified
defect
Not set
critical

Tracking

(firefox56+ fixed)

VERIFIED FIXED
Tracking Status
firefox56 + fixed

People

(Reporter: marsf, Assigned: marsf)

Details

Attachments

(2 files)

In the privacy pane of preference of Firefox 56.0 beta, an unexpected English string remains by mistake. It must be removed.

https://hg.mozilla.org/releases/l10n/mozilla-beta/ja/file/tip/browser/chrome/browser/preferences/privacy.dtd#l22

 <!ENTITY trackingProtectionPBM6.label		"プライベートブラウジングモードでトラッキング保護を使用して既知の追跡者をブロックする
	Use Tracking Protection in Private Browsing to block known trackers">
[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Definitely yes.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): none.
String changes made by this patch: yes.
Attachment #8909259 - Flags: review?(francesco.lodolo)
Assignee: nobody → chimantaea_mirabilis
for fx56 ja-JP-mac
Attachment #8909261 - Flags: review?(francesco.lodolo)
Attachment #8909261 - Flags: review?(francesco.lodolo)
Attachment #8909259 - Flags: review?(francesco.lodolo)
I'm quite confused by this bug:
* You don't need approval to land content in your repository.
* There's no point in landing content in mozilla-beta now, we're past deadline. Also note that, from this cycle, mozilla-beta is unused, only l10n-central will be used (cross-channel).
* An obsolete string in the files is really not an issue.

Simply land the change on l10n-central removing the obsolete string, no urgency.
(In reply to Francesco Lodolo [:flod] from comment #3)
> I'm quite confused by this bug:
> * An obsolete string in the files is really not an issue.

And, right after commenting, I understood the issue :-\

You have a string with mixed English/Japanese content, not an obsolete string.

As said, we're past sign-off for Beta, and the merge beta-release already happened. Please land in l10n-central for now, I'll try to figure out if we can do anything to include a change in Release.
> You have a string with mixed English/Japanese content, not an obsolete string.

Yes, it is my mistake. Sorry.
I have just pushed them without r= flag.

https://hg.mozilla.org/l10n-central/ja/rev/7be8b02a07fe
https://hg.mozilla.org/l10n-central/ja-JP-mac/rev/e4c7122a4fd4
https://hg.mozilla.org/releases/l10n/mozilla-release/ja/rev/0f3bea597ba3
https://hg.mozilla.org/releases/l10n/mozilla-release/ja-JP-mac/rev/7f49be227f5d

@Sylvestre
We found an issue in Japanese post sign-off deadline. Any chance we can take an update?

Currently shipping changesets (according to dashboard and product-details):
ja: 34cddaa3f554
ja-JP-mac: 1cca7e5654d2

New changesets with the fix:
ja: 0f3bea597ba3
ja-JP-mac: 7f49be227f5d
Flags: needinfo?(sledru)
For 56, yes, still time. 302 to Liz, release owner of 56
Flags: needinfo?(sledru) → needinfo?(lhenry)
Thanks. Regarding risks: I've checked the diffs between the changesets, and there's only the string landed in this bug.
Fennec in unaffected.
Yes, we can still take this.  
Do we need to uplift the patch here to m-r?  (If so, please request uplift)
Or should I modify the l10n changeset in ship-it when we go to build ?
Flags: needinfo?(lhenry)
Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(chimantaea_mirabilis)
The patch already landed in m-r (l10n repos), there's no change for mozilla-release code repository, we only need to update the shipping changesets in Ship It.
Flags: needinfo?(francesco.lodolo)
Flags: needinfo?(chimantaea_mirabilis)
Flags: needinfo?(lhenry)
Thanks flod, I updated the changesets when we shipped.  I assume we will need to do that again for the 56 RC2 build.
Flags: needinfo?(lhenry)
(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #11)
> Thanks flod, I updated the changesets when we shipped.  I assume we will
> need to do that again for the 56 RC2 build.

I have no visibility on how Ship It works, but I assume you copy the list of changesets from the previous build?
Magically: I remembered to double check, AND... ship-it had the right info when I went to build 56 RC2. 

Dear QE contact at l10n-qa: can you help verify that this is fixed in the RC2 build? Thank you very much!
Flags: needinfo?(l10n-qa)
Masahiko, can we mark this bug as FIXED? Thanks.
Flags: needinfo?(chimantaea_mirabilis)
Verified fixed.

I have checked the changeset in "l10n_changesets.txt" and tested the program from here:
https://archive.mozilla.org/pub/firefox/candidates/56.0-candidates/build2/

Thank you very much!
Status: NEW → RESOLVED
Closed: 2 years ago
Flags: needinfo?(l10n-qa)
Flags: needinfo?(chimantaea_mirabilis)
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.