1400815 - [ja] Unexpected English string remains in /browser/preferences/privacy.dtd

Status: VERIFIED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Masahiko Imanaka [:marsf]]

In the privacy pane of preference of Firefox 56.0 beta, an unexpected English string remains by mistake. It must be removed.

https://hg.mozilla.org/releases/l10n/mozilla-beta/ja/file/tip/browser/chrome/browser/preferences/privacy.dtd#l22

 <!ENTITY trackingProtectionPBM6.label		"プライベートブラウジングモードでトラッキング保護を使用して既知の追跡者をブロックする
	Use Tracking Protection in Private Browsing to block known trackers">

Comment 1

[Masahiko Imanaka [:marsf]]

Attachment: patch for fx56-ja

[Approval Request Comment]
Regression caused by (bug #): 
User impact if declined: Definitely yes.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): none.
String changes made by this patch: yes.

Comment 2

[Masahiko Imanaka [:marsf]]

Attachment: patch for fx56-ja-JP-mac

for fx56 ja-JP-mac

Comment 3

[Francesco Lodolo [:flod]]

I'm quite confused by this bug:
* You don't need approval to land content in your repository.
* There's no point in landing content in mozilla-beta now, we're past deadline. Also note that, from this cycle, mozilla-beta is unused, only l10n-central will be used (cross-channel).
* An obsolete string in the files is really not an issue.

Simply land the change on l10n-central removing the obsolete string, no urgency.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> I'm quite confused by this bug:
> * An obsolete string in the files is really not an issue.

And, right after commenting, I understood the issue :-\

You have a string with mixed English/Japanese content, not an obsolete string.

As said, we're past sign-off for Beta, and the merge beta-release already happened. Please land in l10n-central for now, I'll try to figure out if we can do anything to include a change in Release.

Comment 5

[Masahiko Imanaka [:marsf]]

> You have a string with mixed English/Japanese content, not an obsolete string.

Yes, it is my mistake. Sorry.
I have just pushed them without r= flag.

https://hg.mozilla.org/l10n-central/ja/rev/7be8b02a07fe
https://hg.mozilla.org/l10n-central/ja-JP-mac/rev/e4c7122a4fd4

Comment 6

[Francesco Lodolo [:flod]]

https://hg.mozilla.org/releases/l10n/mozilla-release/ja/rev/0f3bea597ba3
https://hg.mozilla.org/releases/l10n/mozilla-release/ja-JP-mac/rev/7f49be227f5d

@Sylvestre
We found an issue in Japanese post sign-off deadline. Any chance we can take an update?

Currently shipping changesets (according to dashboard and product-details):
ja: 34cddaa3f554
ja-JP-mac: 1cca7e5654d2

New changesets with the fix:
ja: 0f3bea597ba3
ja-JP-mac: 7f49be227f5d

Comment 7

[Sylvestre Ledru [:Sylvestre]]

For 56, yes, still time. 302 to Liz, release owner of 56

Comment 8

[Francesco Lodolo [:flod]]

Thanks. Regarding risks: I've checked the diffs between the changesets, and there's only the string landed in this bug.
Fennec in unaffected.

Comment 9

[Liz Henry (:lizzard)]

Yes, we can still take this.  
Do we need to uplift the patch here to m-r?  (If so, please request uplift)
Or should I modify the l10n changeset in ship-it when we go to build ?

Comment 10

[Francesco Lodolo [:flod]]

The patch already landed in m-r (l10n repos), there's no change for mozilla-release code repository, we only need to update the shipping changesets in Ship It.

Comment 11

[Liz Henry (:lizzard)]

Thanks flod, I updated the changesets when we shipped.  I assume we will need to do that again for the 56 RC2 build.

Comment 12

[Francesco Lodolo [:flod]]

(In reply to Liz Henry (:lizzard) (needinfo? me) from comment #11)
> Thanks flod, I updated the changesets when we shipped.  I assume we will
> need to do that again for the 56 RC2 build.

I have no visibility on how Ship It works, but I assume you copy the list of changesets from the previous build?

Comment 13

[Liz Henry (:lizzard)]

Magically: I remembered to double check, AND... ship-it had the right info when I went to build 56 RC2. 

Dear QE contact at l10n-qa: can you help verify that this is fixed in the RC2 build? Thank you very much!

Comment 14

[Liz Henry (:lizzard)]

Masahiko, can we mark this bug as FIXED? Thanks.

Comment 15

[Masahiko Imanaka [:marsf]]

Verified fixed.

I have checked the changeset in "l10n_changesets.txt" and tested the program from here:
https://archive.mozilla.org/pub/firefox/candidates/56.0-candidates/build2/

Thank you very much!