1400854 - Fix Watch Expressions + WASM feature flag

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Jason Laster [:jlast]]

This fixes two small 57 regressioons:

* watch expression property loading when active
* WASM, which was accidentally flagged off

Comment 1

[Jason Laster [:jlast]]

Attachment: 9-18-1.patch

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8909307 [details] [diff] [review]
9-18-1.patch

Review of attachment 8909307 [details] [diff] [review]:
-----------------------------------------------------------------

Seems okay for WASM support.
I have trouble understanding the watch expression thing. If we're in a hurry for 57, we should file a follow-up bug to have a test demonstrating the bug is indeed fixed.

::: devtools/client/debugger/new/debugger.js
@@ +21620,5 @@
>          getState = _ref16.getState;
>  
>      var objectId = object.actor || object.objectId;
>  
> +    if ((0, _selectors.getLoadedObject)(getState(), objectId)) {

Why and where it was failing, and what do we do now instead ? 
I have trouble understanding this code.
Maybe you could point me to the non-bundle version ?

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8909307 [details] [diff] [review]
9-18-1.patch

Review of attachment 8909307 [details] [diff] [review]:
-----------------------------------------------------------------

We discussed this in Slack.
The original change is https://github.com/devtools-html/debugger.html/issues/4024, and a test case will be added here https://github.com/devtools-html/debugger.html/blob/master/src/test/mochitest/browser_dbg-expressions.js#L78-L79.

Comment 4

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=afd03eb8882436de7a5f841108b7081df47b3ad2

Comment 5

[Jason Laster [:jlast]]

here is the issue for the test: https://github.com/devtools-html/debugger.html/issues/4025

Comment 6

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cb559403cddc63902c72d65422878bf9123b29d7

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1400854 - Fix Watch Expressions + WASM feature flag.

Review commit: https://reviewboard.mozilla.org/r/181284/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181284/

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 8909791 [details]
Bug 1400854 - Fix Watch Expressions + WASM feature flag.

https://reviewboard.mozilla.org/r/181284/#review186516

Already r+ on splinter

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd2d3ed20c94
Fix Watch Expressions + WASM feature flag. r=nchevobbe

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fd2d3ed20c94