Closed Bug 140087 Opened 22 years ago Closed 22 years ago

Avoid the leak of nsPluginStreamListenerPeer obj when NS_OpenURI() failed

Categories

(Core Graveyard :: Plug-ins, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: srgchrpv, Assigned: srgchrpv)

Details

Attachments

(2 files)

I suddenly run into this leak while tested bug 139563
the test case & patch are following
Attached file test case
because file:///somefile.vaw cannot be found rv = NS_OpenURI() fails 
in nsPluginHostImpl::NewEmbededPluginStream()
Attached patch patch v1Splinter Review
if necko does not addRef on this listener, add & release here will delete the
object.
Av, could you r= on this, please?
Comment on attachment 81035 [details] [diff] [review]
patch v1

r=av, we have NS_ENSURE_ARGUMENT_POINTER macro, can make a use of it here.
Attachment #81035 - Flags: review+
this works now
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
.
Status: RESOLVED → VERIFIED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: