1400871 - Add Custom leanplum template for FxA A/B testing

Status: RESOLVED FIXED

(Firefox for iOS :: Firefox Accounts, enhancement)

Description

[Vijay Budhram]

To help support FxA push notification A/B testing we need to add a flag that does not automatically display native permissions dialog when a user signs in or up. Instead, it would rely on Leanplum framework to prime the user on why they should accept push notifications.

We have started a feature doc that has details on the different types of messaging that will be used, ref: https://docs.google.com/document/d/1W7W5RxbijWAKGingzwltbXMXWjbUlFGcrCWT1U8QArs/edit

To ensure everything is working as expected, this should be tested on non release users and be disabled when Leanplum is disabled.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Vijay, can you set the tracking flags to indicate which release you want to land this on? Thanks!

Comment 2

[Vijay Budhram]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3207

Comment 3

[Vijay Budhram]

Had a vidyo with James and concluded that we need a callback on whether or not a user has allowed or not allowed permissions on the pre-push dialog. This would cover the following scenarios

  * User clicks `Yes` on pre-push and `Yes` on push permission dialog
    * Don't advance account state, state would be advanced when they allow permissions
  * User clicks `Yes` on pre-push and `No` on push permission dialog
    * Advance account with readyToSync
  * User clicks `No` on pre-push
    * Advance account with readyToSync

I sent an email to Leanplum support to see if there was a way to get the callback.

Comment 4

[Vijay Budhram]

Leanplum support recommends that we use a custom template and detect the pre-push dialog.

```
Thanks for outlining your use case. We provide the option with our Custom In-App templates being open sourced for you to make changes and change what happens on message button click. For this particular case what you can do is customize the default action when clicking either the accept or cancel for the Custom messages ->

iOS ->
https://github.com/Leanplum/Leanplum-iOS-SDK/blob/master/Leanplum-SDK/Classes/LPMessageTemplates.m#L506-L525

This would basically be adding a case inside the Accept/Cancel if the message is Push pre permissions and conducting your actions.

Note when making this customization it's up to you to test engagement on all message types to verify they are still working as expected and QA to determine your code is being fired.
```

Comment 5

[Vijay Budhram]

Comment on attachment 8911310 [details] [review]
Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3207

Updated this from previous conversation. Uses a custom leanplum template that gives us hooks on whether or not a user accept/declined pre-permissions. 

  * If user clicks no, do ready for syncing
  * If user clicks yes, present native permissions dialog.

To keep things simple, it utilizes a UIAlert and attaches to the top most view controller.

Comment 6

[Vijay Budhram]

This was landed on master.

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Uplifted to v9.x and v10.x - Currently only enabled on Beta.