1400878 - Don't popup keyboard when input focused without user interaction

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

This seems to be the way other browser work these days. Also, it prevents us from running the Speedometer benchmark without constant keyboard changes.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1400878 - Don't show keyboard on Android unless the user caused it

Review commit: https://reviewboard.mozilla.org/r/180888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180888/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8909332 [details]
Bug 1400878 - Don't show keyboard on Android unless the user caused it

https://reviewboard.mozilla.org/r/180888/#review186078

::: widget/android/GeckoEditableSupport.cpp:1159
(Diff revision 1)
>      if (aContext.mIMEState.mEnabled != IMEState::DISABLED &&
> -        aContext.mIMEState.mEnabled != IMEState::PLUGIN &&
> +        !aAction.IsUserAction() &&
> -        Preferences::GetBool("content.ime.strict_policy", false) &&
> -        !aAction.ContentGotFocusByTrustedCause() &&
>          !aAction.UserMightRequestOpenVKB()) {
>          return;

We won't properly initialize the Java side code if we early return here. We should just not call `showSoftInput` here [1] if a script causes us to focus, maybe by passing a flag into `notifyIMEContext` [2].

[1] http://searchfox.org/mozilla-central/rev/05c4c3bc0cfb9b0fc66bdfc8c47cac674e45f151/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputConnection.java#649
[2] http://searchfox.org/mozilla-central/rev/05c4c3bc0cfb9b0fc66bdfc8c47cac674e45f151/mobile/android/geckoview/src/main/java/org/mozilla/gecko/GeckoInputConnection.java#971

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8909332 [details]
Bug 1400878 - Don't show keyboard on Android unless the user caused it

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/180888/diff/1-2/

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8909332 [details]
Bug 1400878 - Don't show keyboard on Android unless the user caused it

https://reviewboard.mozilla.org/r/180888/#review186270

::: widget/android/GeckoEditableSupport.cpp:1155
(Diff revision 2)
> -        !aAction.ContentGotFocusByTrustedCause() &&
> -        !aAction.UserMightRequestOpenVKB()) {
> -        return;
> -    }
> -
>      IMEState::Enabled enabled = aContext.mIMEState.mEnabled;

You can actually get rid of `enabled` now

::: widget/android/GeckoEditableSupport.cpp:1159
(Diff revision 2)
> -    }
> -
>      mInputContext = aContext;
>      mInputContext.mIMEState.mEnabled = enabled;
>  
> -    if (enabled == IMEState::ENABLED && aAction.UserMightRequestOpenVKB()) {
> +    if (enabled == IMEState::ENABLED && aAction.UserMightRequestOpenVKB() && aAction.IsUserAction()) {

`UserMightRequestOpenVKB()` already implies `IsUserAction()`

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e16f505b25f
Don't show keyboard on Android unless the user caused it r=jchen

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7e16f505b25f

Comment 10

[Sorina Florean [:sflorean]]

Verified as fixed on latest Nightly build with Huawei Honor (Android 5.1.1), Honor 8 (Android 7.0) and Asus ZenPad 8(Android 6.0.1).

Comment 11

[luis.pabon]

Verified also on today's Nightly on Nexus 6p / Android Oreo. Thank you!