1400898 - Nix some nsIDOMChromeWindow stuff

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Boris Zbarsky [:bzbarsky]]

There's no good reason for nsIDOMChromeWindow to be scriptable, for example.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Actually, I guess it needs to be scriptable so it shows up in Ci.nsIDOMChromeWindow.... :(

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Remove the one script use of nsIDOMChromeWindow

MozReview-Commit-ID: I31eceiJP55

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Get rid of the interface constants on nsIDOMChromeWindow

MozReview-Commit-ID: 4FuJSgha5y3

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Make nsIDOMChromeWindow.browserDOMWindow readonly

C++ code only reads this attribute.  Code that sets it comes via WebIDL bindings.

MozReview-Commit-ID: 2itFAxUVTBo

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: part 4. Get rid of nsIDOMChromeWindow methods that are unused from C++, and mark the rest [noscript]

MozReview-Commit-ID: GtYmfg6XiaQ

Comment 6

[Andreas Farre [:farre]]

Comment on attachment 8909354 [details] [diff] [review]
part 2.  Get rid of the interface constants on nsIDOMChromeWindow

Review of attachment 8909354 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsGlobalWindow.cpp
@@ +14076,5 @@
>    return NS_OK;
>  }
>  
> +enum WindowState {
> +  // These constants need to match the cosntants in Window.webidl

s/cosntants/constants/

Comment 7

[Boris Zbarsky [:bzbarsky]]

> s/cosntants/constants/

Good catch, fixed.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4ef5b6299e5
part 1.  Remove the one script use of nsIDOMChromeWindow.  r=farre
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa4d0a9412c0
part 2.  Get rid of the interface constants on nsIDOMChromeWindow.  r=farre
https://hg.mozilla.org/integration/mozilla-inbound/rev/081034bdc4d4
part 3.  Make nsIDOMChromeWindow.browserDOMWindow readonly.  r=farre
https://hg.mozilla.org/integration/mozilla-inbound/rev/5af3e3b70198
part 4.  Get rid of nsIDOMChromeWindow methods that are unused from C++, and mark the rest [noscript].  r=farre

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4ef5b6299e5
https://hg.mozilla.org/mozilla-central/rev/aa4d0a9412c0
https://hg.mozilla.org/mozilla-central/rev/081034bdc4d4
https://hg.mozilla.org/mozilla-central/rev/5af3e3b70198