Closed Bug 1400962 Opened 2 years ago Closed 2 years ago
[RTL] Flip some icons on the Activity Stream
52 bytes, text/x-github-pull-request
|Details | Review|
All pin/unpin related icons should be mirrored on RTL. Same for all "Open in a New Window" icons.
Hey! Can I work on this?
Sure! The icon styles should be here https://github.com/mozilla/activity-stream/blob/master/system-addon/content-src/styles/_icons.scss
Assignee: nobody → vikasmahato0
I am unable to reproduce the issue. I am facing two problems: 1. How to enable RTL layout. 2. Locating these icons in firefox https://user-images.githubusercontent.com/438537/30559292-00333026-9c69-11e7-98c1-22b201f296a6.png Can you help me with this?
Hi! If you open the Developer Console in Firefox you can set in the Inspector tab the class of the <html> element to "rtl" to simulate right to left mode (you'll probably notice it has the "ltr" class). Most of the icons are here https://github.com/mozilla/activity-stream/tree/68627453a839d7a21db33ea1e108bd90a12d0ccf/system-addon/data/content/assets You'll need to follow these steps to set up development https://github.com/mozilla/activity-stream/blob/68627453a839d7a21db33ea1e108bd90a12d0ccf/docs/v2-system-addon/1.GETTING_STARTED.md Here is an example of how we target RTL mode with css https://github.com/mozilla/activity-stream/blob/68627453a839d7a21db33ea1e108bd90a12d0ccf/system-addon/content-src/components/TopSites/_TopSites.scss#L251-L253
I have sent a pull request. Please let me know if anything needs to be changed.
Itiel, should the highlights icon (the big star with 2 smaller stars) be flipped too? See screenshots in https://github.com/mozilla/activity-stream/pull/3946#issuecomment-359146949
(In reply to Ed Lee :Mardak from comment #7) > Itiel, should the highlights icon (the big star with 2 smaller stars) be > flipped too? See screenshots in > https://github.com/mozilla/activity-stream/pull/3946#issuecomment-359146949 I don't think that would be needed, I see no reason to do so. But the Edit icon should remain as-is, and not get the flip-icon treatment.
I have updated the pull request and removed the flip-icon property from Edit icon
Commit pushed to master at https://github.com/mozilla/activity-stream https://github.com/mozilla/activity-stream/commit/7b6573a1a95a556d39f6a6673821c0bd6b4be7d5 fix(styles): Add mixin to flip some icons for rtl (#3946) Fix Bug 1400962 - [RTL] Flip some icons on the Activity Stream
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.