1400963 - scrolling out in json viewer

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect, P3)

Description

[yuraantonov11]

Attachment: Screenshot_1.jpg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170918100059

Steps to reproduce:

I open developer tools with ajax request witch returns json.


Actual results:

when i select some row in response and move down with arrows on keyboard, selected row in json goes beyond


Expected results:

when i select some row in response and move down with arrows on keyboard, selected row in json should not go beyond, and json should scroll down

Comment 1

[YF (Yang)]

Also occurs when open an json (json viewer) and scrolling.

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: Bug 1400963 - Scroll selected row into view in JSON Viewer.

Review commit: https://reviewboard.mozilla.org/r/195408/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195408/

Comment 3

[Oriol Brufau [:Oriol]]

Comment on attachment 8924147 [details]
Bug 1400963 - Scroll selected row into view in JSON Viewer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195408/diff/1-2/

Comment 4

[Oriol Brufau [:Oriol]]

`document` is not available in the DOM panel, which uses TreeView too. So I switched to `ReactDOM.findDOMNode`.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8924147 [details]
Bug 1400963 - Scroll selected row into view in JSON Viewer.

https://reviewboard.mozilla.org/r/195408/#review200988

Thanks for the patch!

R+ assuming try is green

Honza

::: devtools/client/jsonview/test/browser_jsonview_row_selection.js:12
(Diff revision 2)
> +
> +add_task(function* () {
> +  info("Test JSON row selection started");
> +
> +  // Create a tall JSON so that there is a scrollbar.
> +  let numRows = 1e3;

heh, creative way to say `1000` ;-)

Comment 6

[Jan Honza Odvarko [:Honza] (always need-info? me)]

There was a conflict in browser.ini when I applied the patch.
You might want to check it out before landing.

Honza

Comment 7

[Oriol Brufau [:Oriol]]

Comment on attachment 8924147 [details]
Bug 1400963 - Scroll selected row into view in JSON Viewer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195408/diff/2-3/

Comment 8

[Oriol Brufau [:Oriol]]

(In reply to Jan Honza Odvarko [:Honza] from comment #6)
> There was a conflict in browser.ini when I applied the patch.

Thanks, rebased the patch.

(In reply to Jan Honza Odvarko [:Honza] from comment #5)
> heh, creative way to say `1000` ;-)

I tend to use exponential notation for big numbers; not much useful for 1000, though.

Comment 9

[Mozilla Autoland]

hg error in cmd: hg rebase -s bd3edec1b462 -d 1c1e25c461a0: abort: can't rebase public changeset bd3edec1b462
(see 'hg help phases' for details)

Comment 10

[Oriol Brufau [:Oriol]]

I don't understand, what am I supposed to do to?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Redirecting to someone who knows MozReview :)

Comment 12

[Oriol Brufau [:Oriol]]

Comment on attachment 8924147 [details]
Bug 1400963 - Scroll selected row into view in JSON Viewer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195408/diff/3-4/

Comment 13

[Oriol Brufau [:Oriol]]

Fixed a typo in the test. I still don't know what's with this phases problem.

Comment 14

[Mark Côté [:mcote]]

glob, you know what's happening here?

Comment 15

[:glob ✱]

db7d4a3601e5's phase is public; it should be draft:
> $ hg log -T '{node} {phase}\n' -r db7d4a3601e5
> db7d4a3601e51281e1c8057acdfcb500c415b65d public

the revision from comment 12 looks correct:
> $ hg log -T '{node} {phase}\n' -r a5606bc28432
> a5606bc28432368fe5d4e7f9285d61cf04997cef draft

i can't tell how db7d4a3601e5 was changed to public – it's likely this was an accidental action by oriol.

setting checkin-needed as it looks like a5606bc28432 should be ok.

Comment 16

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 03d59dbc349a -d e412b3da631e: rebasing 432460:03d59dbc349a "Bug 1400963 - Scroll selected row into view in JSON Viewer. r=Honza" (tip)
merging devtools/client/shared/components/tree/TreeView.js
warning: conflicts while merging devtools/client/shared/components/tree/TreeView.js! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 17

[Oriol Brufau [:Oriol]]

Comment on attachment 8924147 [details]
Bug 1400963 - Scroll selected row into view in JSON Viewer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195408/diff/4-5/

Comment 18

[Oriol Brufau [:Oriol]]

Comment on attachment 8924147 [details]
Bug 1400963 - Scroll selected row into view in JSON Viewer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195408/diff/5-6/

Comment 19

[Oriol Brufau [:Oriol]]

Rebased the patch

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba9156f71b76
Scroll selected row into view in JSON Viewer. r=Honza

Comment 21

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/ba9156f71b76