1400986 - Be more lenient with profile unbundling problems while upgrading SyncPrefs

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Firefox Accounts, enhancement, P5)

Description

[:Grisha Kruglov]

Bug 1368147 landed a change in where SyncPrefs are stored. This required an upgrade operation, which involves reading and parsing our persisted fxa.account.json file to obtain FxA UID.

Bug 1399904 demonstrated that we might fail to do so, and crash as a result. In that bug, additional code landed which will help surface underlying problems - at the time of filing, we're yet to see follow-up crashes, and so the root cause is still unknown (and likely to be varied, although Nick hypothesizes that we'll see JSON-failed-to-parse reports).

I hypothesize that we're going to see a spike in crashes similar to Bug 1399904 once another batch of users runs through this upgrade process. Our approach in case of profile parsing failures prior to Bug 1368147 was to behave as if we don't have a Firefox Account. That seems sensible (though not ideal) - user's only recourse is to re-login into their account.

This problem is somewhat complicated by the fact that we don't have a single point of entry into this logic anymore. Before, we'd hit these issues while obtaining a Firefox Account representation, and failures would present themselves as "there's no firefox account".

The high level goal here is to ensure we don't crash or otherwise get user stuck in a bad state in case of corrupt fxa.account.json file (or, at least, seemingly corrupt, such that org.json.simple is failing to parse it).

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.