1401017 - mach try with -j syntax still doesn't quite work

Status: RESOLVED FIXED

(Testing :: General, enhancement)

Description

[Chris Manchester (limited bugmail, email directly)]

This conflicts weirdly with another disused feature.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1401017 - Make mach try work with -j in the presence of modified local files.

Running |./mach try -j <job>| may fail if there are changes in the local
working copy because the command will attempt to provide test paths based
on those changes and subsequently require platforms to be specified on the
basis of those paths. This commit makes this auto-detection only run when
a particular option is passed so this doesn't interfere with the common
case of simply running a selected job on try.

Review commit: https://reviewboard.mozilla.org/r/180976/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180976/

Comment 2

[Andrew Halberstadt [:ahal]]

Comment on attachment 8909499 [details]
Bug 1401017 - Make mach try work with -j in the presence of modified local files.

https://reviewboard.mozilla.org/r/180976/#review186474

Thanks, lgtm!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/736a50d4556d
Make mach try work with -j in the presence of modified local files. r=ahal

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/736a50d4556d