1401018 - about:addons search steals focus from add-on preferences textbox

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Andrew Swan [:aswan]]

+++ This bug was initially created as a clone of Bug #1381032 +++

The fix in bug 1381032 handled this problem when OOP webextensions are enabled, but not if they are disabled.  Cloning to handle the latter case separately.

STR:
1) Install Gecko Profiler from https://perf-html.io
2) Navigate to about:addons -> Extensions -> Gecko Profiler [Options]
3) Type a URL (containing forward slash) into |Profile viewer URL| box

Expected:
Can enter a URL including forward slashes

Actual:
A forward slash in URL appears in textbox, then focus switches to settings searchbar and rest of URL appears there.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1401018 Don't let about:addons steal keypresses from options pages

Revise the bug 1381032 fix to work whether or not oop webextensions
are enabled.

Review commit: https://reviewboard.mozilla.org/r/180984/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/180984/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8909508 [details]
Bug 1401018 Don't let about:addons steal keypresses from options pages

https://reviewboard.mozilla.org/r/180984/#review186302

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/de928fb12391
Don't let about:addons steal keypresses from options pages r=kmag

Comment 4

[Andrew Swan [:aswan]]

Krupa, can we get a little extra QA attention on this?  I'm pretty confident that we're addressing the original symptom properly but want to make sure we're not inadvertently stealing keypresses for other things (i.e., browser level keyboard shortcuts, etc)

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/de928fb12391

Comment 6

[Oana Botisan, Desktop QA]

Based on the testing I did for the bug 1381032, the result of which you can find accessing this link https://bugzilla.mozilla.org/show_bug.cgi?id=1381032#c13, I think this bug can be closed.

Comment 7

[marius.santa]

This bug is verified on Firefox 57.0b9 (20171016185129) and Firefox 58.0a1 (20171016100113) under Windows 10 64bit/Mac OS X 10.13.