1401089 - The "Pocket Button" in the pocket doorhanger pointing to the page actions menu refers to a button that has been renamed (when the "Pocket Button" has been manually removed by the user)

Status: NEW

(Firefox :: Pocket, defect, P5)

Description

[(no longer active)]

It is now called Save Page to Pocket.  Also the doorhanger popup doesn't really clarify that it's pointing to a menu item inside the menu which will be opened when you click the "..." icon.

See the screenshot.

Comment 1

[Marius Coman [:mcoman], Ecosystem QA]

Ehsan, your comment says "See the screenshot", but there is no screenshot attached. Could you please reattach it?
Also, do you need to be logged into Pocket to reproduce the issue?

Comment 2

[(no longer active)]

Attachment: Screenshot

Comment 3

[(no longer active)]

(In reply to Marius Coman [:cmarius] from comment #1)
> Ehsan, your comment says "See the screenshot", but there is no screenshot
> attached. Could you please reattach it?

Oops, sorry I forgot to attach it!

> Also, do you need to be logged into Pocket to reproduce the issue?

No, I don't think this is related to the logged in state.  But I wasn't logged in, FWIW.

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

On a new profile the "Pocket" button is displayed by default in the address bar between "Page action" and "Bookmarks" buttons.
Ehsan, are you sure that you haven't removed the "Pocket" button by accident? You can verify this by right clicking the "Save Page to Pocket" option from the "Page actions" menu.

Comment 5

[(no longer active)]

Sorry, you're right.  I have been doing some testing with a new profile and filing bugs and thought this bug was one of those, my apologies.  This is filed from my main browsing profile which isn't a new profile, and I have hidden the pocket button by right clicking on it and choosing Remove from Address Bar.

Selecting Save Page to Pocket from the context menu causes the same doorhanger as the one in the screenshot to open up, pointing to the "..." button.

Comment 6

[Julien Cristau [:jcristau]]

Since this only affects profiles where the button has been removed, it doesn't seem worth tracking for 57.

Comment 7

[:Gijs (he/him)]

This takes strings to fix, so it's not going to make 57. Also seems pretty low-prio given people aren't very likely to *first* remove the button and *then* go "hey, let's actually try to use this".