Closed
Bug 1401105
Opened 7 years ago
Closed 7 years ago
Fix the failure of keypath-special-identifiers.htm
Categories
(Core :: Storage: IndexedDB, enhancement, P3)
Core
Storage: IndexedDB
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: bevis, Assigned: bevis)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1.78 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
This failure is caused by the restriction of "aOptions == DoNotCreateProperties" according to bug 1178803 comment 2: http://searchfox.org/mozilla-central/rev/1c13d5cf85f904afb8976c02a80daa252b893fca/dom/indexedDB/KeyPath.cpp#110 However, I see no reason why we need this after reviewing the implementation, so I'd like to remove it to fix this problem.
Updated•7 years ago
|
Priority: -- → P3
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8911064 -
Flags: review?(amarchesini)
Updated•7 years ago
|
Attachment #8911064 -
Flags: review?(amarchesini) → review+
Pushed by btseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8d1f71c4d315 Fix the failure of keypath-special-identifiers.htm. r=baku
Comment 3•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8d1f71c4d315
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•