1401107 - Use ContiguousEnumSerializer for enum types in PluginMessageUtils.h

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement, P3)

Description

[Julian Hector [:tedd] [:jhector]]

Currently a custom implementation for enum serialization in PluginMessageUtils.h [1] is used, however, helper classes exists [2] which do the proper enum serialization/deserialization along with the value range validation. An example use of this helper class can be found here [3].

The same practice should be used for the enum types in PluginMessageUtils.h

[1] http://searchfox.org/mozilla-central/rev/1c13d5cf85f904afb8976c02a80daa252b893fca/dom/plugins/ipc/PluginMessageUtils.h#377,674,695,718
[2] http://searchfox.org/mozilla-central/rev/05c4c3bc0cfb9b0fc66bdfc8c47cac674e45f151/ipc/glue/IPCMessageUtils.h#212
[3] http://searchfox.org/mozilla-central/rev/1c13d5cf85f904afb8976c02a80daa252b893fca/dom/bindings/ErrorIPCUtils.h#17-21

Comment 1

[Julian Hector [:tedd] [:jhector]]

Attachment: NOT TESTED - Convert ParamTraits specialization to use helper struct

This is untested, but compiles cleanly.

Comment 2

[Alex Gaynor [:Alex_Gaynor]]

Any chance you can make some time to look at this? It looks good to me.

Comment 3

[Alex Gaynor [:Alex_Gaynor]]

Attachment: 1401107.patch

Update the patch to include a commit message. Swaps out the ni? for an r?.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b223c9694142
Use ContiguousEnumSerializer for ParamTraits in npapi; r=jimm

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b223c9694142