1401118 - Avoid having to modify replace-malloc.mk every time we add an allocator API entry point

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1401118 - Avoid having to modify replace-malloc.mk every time we add an allocator API entry point.

For obscure linkage reasons, we need all the replace-malloc symbols
being passed to the linker to tell it to allow them being undefined.

That list actually duplicates what's in malloc_decls.h somehow, and
every time we add an entry point, we end up having to modify those two
files (and others, addressed in different bugs), which is suboptimal.

So we generate the list of those symbols from malloc_decls.h.

Review commit: https://reviewboard.mozilla.org/r/181208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181208/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8909677 [details]
Bug 1401118 - Avoid having to modify replace-malloc.mk every time we add an allocator API entry point.

https://reviewboard.mozilla.org/r/181208/#review186492

::: mozglue/build/replace_malloc.mk:8
(Diff revision 1)
>  OS_LDFLAGS += \
> -  -Wl,-U,_replace_init \
> +  $(shell awk -F'[(),]' '/^MALLOC_DECL/{print "-Wl,-U,_replace_" $$2}' $(topsrcdir)/memory/build/malloc_decls.h) \

Adding `$(shell)` to Makefiles is not super-conducive to getting rid of Makefiles, but I suppose this is not horrible.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0ed0593535e0
Avoid having to modify replace-malloc.mk every time we add an allocator API entry point. r=froydnj

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0ed0593535e0