1401130 - Show correct title for Deep Link

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement, P5)

Description

[Nevin Chen(Not active on Bugzilla)]

Current design don't allow second level preference as title.
Only preference headers can set title.

We should fix this and make deep-linking to non-header preferences to show title correctly.

This is a follow up bug from bug 1379793.

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1401130 - Show title correctly for deep links.

Review commit: https://reviewboard.mozilla.org/r/181224/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181224/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8909703 [details]
Bug 1401130 - Show title correctly for deep links.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181224/diff/1-2/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

The idea for this patch is:
if it's a tablet, title is always "Setting"
otherwise it should be the preferenceScreen's title (e.g. Home)

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8909703 [details]
Bug 1401130 - Show title correctly for deep links.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181224/diff/2-3/

Comment 5

[Richard Newman [:rnewman]]

Did you test this with in-app locale switching? E.g., do the settings page titles change correctly to the new locale on your way back out of the locale switcher?

Comment 6

[Nevin Chen(Not active on Bugzilla)]

yes. in-app locale switching works with title.
I've tested on a multi-locale build

Comment 7

[Richard Newman [:rnewman]]

I've tested this patch locally on a tablet, and it seems fine in normal use, but I don't know how to trigger a deep link. Could you advise how this should be tested?

Comment 8

[Nevin Chen(Not active on Bugzilla)]

I use 
"adb shell am start -a android.intent.action.VIEW -d  "firefox://preferences_home" org.mozilla.fennec_nechen" to test deep links
Currently, valid deep links are here https://searchfox.org/mozilla-central/source/mobile/android/base/java/org/mozilla/gecko/deeplink/DeepLinkContract.java

Preferences related are started with "preferences_"

Comment 9

[Richard Newman [:rnewman]]

I tested deep linking by running

adb shell am start -a android.intent.action.VIEW -d  "firefox://preferences_home" org.mozilla.fennec_rnewman

with Firefox backgrounded.

Positive result:

- Settings opened to the Home tab.

Bugs:

- The breadcrumb trail was wrong: only "Home" shows, not "General > Home". This means you can't get back to General settings without toggling to a different settings category (e.g., Search) and back again.
  - Tapping "General" in the left sidebar does nothing.
- Hitting the back arrow at the top of the Settings window acts like the back button, leaving Firefox altogether, rather than going to BrowserApp.
- Once Settings is opened in this way, picking a different locale inside the language picker will kill and relaunch Firefox back to the home screen.

I think there's some push/pop logic missing here.

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Hi Joe, Wesly
Please advise the priority here.

1. Deep Links for second leve settings (General -> Home/Language) needs to show browserapp and top level setting page first. (Not implemented)
2. Deep Links for settings need to show title correctly (currently the title will be "Firefox" , but it should be "General / Home" (Patched for this bug attatched)

Comment 11

[Wesly Huang (EPM)]

unless Joe has other say, I would propose P3 first.

Comment 12

[Richard Newman [:rnewman]]

Comment on attachment 8909703 [details]
Bug 1401130 - Show title correctly for deep links.

I think that means this is r- until the fix is complete.

Comment 13

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 14

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.