Update hard-coded SUMO link to Safe Browsing page

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: johannh, Assigned: vedantc98, Mentored)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

In bug 1363051 and bug 1359289 we added hard-coded SUMO links because we were lacking an in-product URL. Once we hear back from Joni we should replace these with ones that were properly formatted with app.support.baseURL.

https://searchfox.org/mozilla-central/search?q=how-does-phishing-and-malware-protection-work&case=false&regexp=false&path=
Flags: needinfo?(jsavage)
Mentor: jhofmann
Priority: -- → P3
Hi Johann,

Here is the proper in-product URL: https://support.mozilla.org/1/firefox/%VERSION%/%OS%/%LOCALE%/phishing-malware

Please let me know if that doesn't fix the issue.
Flags: needinfo?(jsavage)
Thank you! Vedant, would you like to take this bug and update the URLs?
Flags: needinfo?(vedantc98)
Hey Johann, thanks, and sorry for not getting back sooner.
Yes, I'll update the link. 
Thanks again !
Flags: needinfo?(vedantc98)
Assignee: nobody → vedantc98
Status: NEW → ASSIGNED
Any update? :)

Feel free to unassign yourself if you don't have time right now or reach out to me on IRC if you need help.
Flags: needinfo?(vedantc98)
I've just finished working on this bug, I'll push a patch and add you for review now.
Flags: needinfo?(vedantc98)
Comment on attachment 8921383 [details]
Bug 1401137 - Updated hard-coded SUMO link to the safe browsing page.

https://reviewboard.mozilla.org/r/192410/#review197558

Looks great, thank you!
Attachment #8921383 - Flags: review?(jhofmann) → review+
Oh, this never got checked in, ha! Let me do that for you...
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/daea037cd968
Updated hard-coded SUMO link to the safe browsing page. r=johannh
https://hg.mozilla.org/mozilla-central/rev/daea037cd968
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.