1401148 - Same Unicode extension sequence keyword values misreported as duplicate variants

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, defect)

Description

[André Bargull [:anba]]

STR:
---
Intl.Collator("de-u-kn-false-kf-false")
---

Expected: Creates a collator with numeric=false and caseFirst=false
Actual: Throws a RangeError

Comment 1

[André Bargull [:anba]]

Attachment: bug1401148.patch

The RegExp to detect duplicate variants was missing an anchor to start matching at the start of the string.

Comment 2

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 8909737 [details] [diff] [review]
bug1401148.patch

So... that's why Igalia people thought we don't support caseFirst... :)

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

Thanks Andre!

Comment 4

[André Bargull [:anba]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2)
> Comment on attachment 8909737 [details] [diff] [review]
> bug1401148.patch
> 
> So... that's why Igalia people thought we don't support caseFirst... :)

Only using "kf", like in Intl.Collator("de-u-kf-false"), actually already works without the patch, it's just having "false" in two Unicode extension keywords which triggered a RangeError. Maybe they were testing on an old Firefox version, we only added caseFirst support in Firefox 55 (bug 866473). :-)

Comment 5

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=870329d65fc96d37befc13269ffca15d95693ef1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c07a2daeb744
Don't count duplicate extension sequence values as variants in BCP49 language tags. r=gandalf

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c07a2daeb744