Closed Bug 1401148 Opened 6 years ago Closed 6 years ago
Same Unicode extension sequence keyword values misreported as duplicate variants
STR: --- Intl.Collator("de-u-kn-false-kf-false") --- Expected: Creates a collator with numeric=false and caseFirst=false Actual: Throws a RangeError
The RegExp to detect duplicate variants was missing an anchor to start matching at the start of the string.
Attachment #8909737 - Flags: review?(gandalf)
Comment on attachment 8909737 [details] [diff] [review] bug1401148.patch So... that's why Igalia people thought we don't support caseFirst... :)
Attachment #8909737 - Flags: review?(gandalf) → review+
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #2) > Comment on attachment 8909737 [details] [diff] [review] > bug1401148.patch > > So... that's why Igalia people thought we don't support caseFirst... :) Only using "kf", like in Intl.Collator("de-u-kf-false"), actually already works without the patch, it's just having "false" in two Unicode extension keywords which triggered a RangeError. Maybe they were testing on an old Firefox version, we only added caseFirst support in Firefox 55 (bug 866473). :-)
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c07a2daeb744 Don't count duplicate extension sequence values as variants in BCP49 language tags. r=gandalf
You need to log in before you can comment on or make changes to this bug.