Closed Bug 1401180 Opened 2 years ago Closed 2 years ago

Rename toolchain transform to use_toolchain

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla57

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(1 file)

To avoid confusion..
Comment on attachment 8909761 [details]
Bug 1401180: rename 'toolchain' transform to 'use_toolchains';

https://reviewboard.mozilla.org/r/181260/#review186998
Attachment #8909761 - Flags: review?(mh+mozilla) → review+
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78dd40f48c52
rename 'toolchain' transform to 'use_toolchains'; r=glandium
https://hg.mozilla.org/mozilla-central/rev/78dd40f48c52
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
I am sort of confused, we had accidentally been running linux64-ccov builds + a talos job on autoland (should only be on mozilla-central), then when this landed it stopped doing that (i.e. it fixed the issue):
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=ccov&fromchange=edc888ae6c3e637a444765a6e4b07d224a1aa1f9

I am curious why this was needed, was there another change that broke things which this fixed?
That's really weird.  No, this is literally just renaming a transform module because every time I looked at it I got confused about what it did.

It looks like the ccov thing was running intermittently before this landed, so maybe another nearby patch did it?  By the same logic, it looks like https://hg.mozilla.org/integration/autoland/rev/1bd12fd8c15ec2cf6959967be015f5eb080e4ecd introduced ccov on autoland, which seems equally illogical!
yeah, it seemed odd to me as well :)
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.