Remove obsolete character menu entities

VERIFIED FIXED in mozilla1.0.1

Status

()

Core
Internationalization
VERIFIED FIXED
16 years ago
16 years ago

People

(Reporter: bobj, Assigned: nhottanscp)

Tracking

({intl})

Trunk
mozilla1.0.1
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

16 years ago
These entities are obsolete (used for previous charset menu implementation).
In the meantime, in is not necessary to localized these.

messenger.dtd:

    ...
    <!ENTITY dcharMenu.label "Character Set  ISO">
    <!ENTITY dcharMenu1.label "Character Set  Multibyte">
    <!ENTITY dcharMenu2.label "Character Set  Cyrillic">
    <!ENTITY dcharMenu3.label "Character Set  SE Asian/Armenian">
    <!ENTITY dcharMenu4.label "Character Set  Macintosh">
    <!ENTITY dcharMenu5.label "Character Set  Windows">
    <!ENTITY dcharIso1Cmd.label "Western (ISO-8859-1)">
    <!ENTITY dcharIso2Cmd.label "Central European (ISO-8859-2)">
    <!ENTITY dcharIso3Cmd.label "South European (ISO-8859-3)">
    <!ENTITY dcharIso4Cmd.label "Baltic (ISO-8859-4)">
    <!ENTITY dcharIso9Cmd.label "Turkish (ISO-8859-9)">
    <!ENTITY dcharIso10Cmd.label "Nordic (ISO-8859-10)">
    <!ENTITY dcharIso13Cmd.label "Baltic (ISO-8859-13)">
    <!ENTITY dcharIso14Cmd.label "Celtic (ISO-8859-14)">
    <!ENTITY dcharIso15Cmd.label "Western (ISO-8859-15)">
    <!ENTITY dcharWinLat2Cmd.label "Central European (Windows-1250)">
    <!ENTITY dcharWinLat1Cmd.label "Western (Windows-1252)">
    <!ENTITY dcharWinLat5Cmd.label "Turkish (Windows-1254)">
    <!ENTITY dcharWinBalRimCmd.label "Baltic (Windows-1257)">
    <!ENTITY dcharMacRomCmd.label "Western (MacRoman)">
    <!ENTITY dcharMacCenEuroCmd.label "Central European (MacCE)">
    <!ENTITY dcharMacTurCmd.label "Turkish (MacTurkish)">
    <!ENTITY dcharMacCroaCmd.label "Croatian (MacCroatian)">
    <!ENTITY dcharMacRomanianCmd.label "Romanian (MacRomanian)">
    <!ENTITY dcharMacIceCmd.label "Icelandic (MacIcelandic)">
    <!ENTITY dcharJapanCmd.label "Japanese (ISO-2022-JP)">
    <!ENTITY dcharJapanShiftjsCmd.label "Japanese (Shift_JIS)">
    <!ENTITY dcharJapanEucCmd.label "Japanese (EUC-JP)">
    <!ENTITY dcharTradChiBigCmd.label "Chinese Traditional (Big5)">
    <!ENTITY dcharTriChiEucCmd.label "Chinese Traditional (EUC-TW)">
    <!ENTITY dcharSimpChiGbCmd.label "Chinese Simplified (GB2312)">
    <!ENTITY dcharKoreanCmd.label "Korean (EUC-KR)">
    <!ENTITY dcharUtf7Cmd.label "Unicode (UTF-7)">
    <!ENTITY dcharUtf8Cmd.label "Unicode (UTF-8)">
    <!ENTITY dcharIsoCyrCmd.label "Cyrillic (ISO-8859-5)">
    <!ENTITY dcharEcmaCyrCmd.label "Cyrillic (ISO-IR-111)">
    <!ENTITY dcharDosCyrCmd.label "Cyrillic (CP-866)">
    <!ENTITY dcharWinCyrCmd.label "Cyrillic (Windows-1251)">
    <!ENTITY dcharMacCyrCmd.label "Cyrillic (MacCyrillic)">
    <!ENTITY dcharMacUkrCmd.label "Cyrillic/Ukrainian (MacUkrainian)">
    <!ENTITY dcharRusCmd.label "Cyrillic (KOI8-R)">
    <!ENTITY dcharUkrCmd.label "Cyrillic/Ukrainian (KOI8-U)">
    <!ENTITY dcharIsoGreekCmd.label "Greek (ISO-8859-7)">
    <!ENTITY dcharWinGreekCmd.label "Greek (Windows-1253)">
    <!ENTITY dcharMacGreekCmd.label "Greek (MacGreek)">
    <!ENTITY dcharWinVietCmd.label "Vietnamese (Windows-1258)">
    <!ENTITY dcharVietTcnCmd.label "Vietnamese (TCVN5712)">
    <!ENTITY dcharVietViCmd.label "Vietnamese (VISCII)">
    <!ENTITY dcharVieVpCmd.label "Vietnamese (VPS)">
    <!ENTITY dcharThaiCmd.label "Thai (TIS-620)">
    <!ENTITY dcharArmCmd.label "Armenian (ARMSCII-8)">
    <!ENTITY dcharIso6Cmd.label ".Arabic (ISO-8859-6)">
    <!ENTITY dcharIso8Cmd.label ".Hebrew (ISO-8859-8)">
    <!ENTITY dcharCp1255Cmd.label "Hebrew (Windows-1255)">
    <!ENTITY dcharCp1256Cmd.label "Arabic (Windows-1256)">
    ... 

editorOverlay.dtd:

    ...
    <!-- Charset menu items -->
    <!ENTITY dcharMenu.label "Character Set  ISO">
    <!ENTITY viewcharsetmenu.accesskey "">
    <!ENTITY dcharMenu1.label "Character Set  Multibyte">
    <!ENTITY viewcharsetmenu1.accesskey "">
    <!ENTITY dcharMenu2.label "Character Set  Cyrillic">
    <!ENTITY viewcharsetmenu2.accesskey "">
    <!ENTITY dcharMenu3.label "Character Set  SE Asian/Armenian">
    <!ENTITY viewcharsetmenu3.accesskey "">
    <!ENTITY dcharMenu4.label "Character Set  Macintosh">
    <!ENTITY viewcharsetmenu4.accesskey "">
    <!ENTITY dcharMenu5.label "Character Set  Windows">
    <!ENTITY viewcharsetmenu5.accesskey "">
    <!-- LOCALIZATION NOTE (dcharIso1Cmd.label): Don't translate the
    ISO code -->
    <!ENTITY dcharIso1Cmd.label "Western (ISO-8859-1)">
    <!ENTITY charsetLatin1.accesskey "">
    <!ENTITY dcharIso2Cmd.label "Central European (ISO-8859-2)">
    <!ENTITY charsetLatin2.accesskey "">
    <!ENTITY dcharIso3Cmd.label "South European (ISO-8859-3)">
    <!ENTITY charsetLatin3.accesskey "">
    <!ENTITY dcharIso4Cmd.label "Baltic (ISO-8859-4)">
    <!ENTITY charsetLatin4.accesskey "">
    <!ENTITY dcharIso9Cmd.label "Turkish (ISO-8859-9)">
    <!ENTITY charsetLatin5.accesskey "">
    <!ENTITY dcharIso10Cmd.label "Nordic (ISO-8859-10)">
    <!ENTITY charsetLatin6.accesskey "">
    <!ENTITY dcharIso13Cmd.label "Baltic (ISO-8859-13)">
    <!ENTITY charsetLatin7.accesskey "">
    <!ENTITY dcharIso14Cmd.label "Celtic (ISO-8859-14)">
    <!ENTITY charsetLatin8.accesskey "">
    <!ENTITY dcharIso15Cmd.label "Western (ISO-8859-15)">
    <!ENTITY charsetLatin9.accesskey "">
    <!ENTITY dcharWinLat2Cmd.label "Central European (Windows-1250)">
    <!ENTITY charsetWinLatin2.accesskey "">
    <!ENTITY dcharWinLat1Cmd.label "Western (Windows-1252)">
    <!ENTITY charsetWinLatin1.accesskey "">
    <!ENTITY dcharWinLat5Cmd.label "Turkish (Windows-1254)">
    <!ENTITY charsetWinLatin5.accesskey "">
    <!ENTITY dcharWinBalRimCmd.label "Baltic (Windows-1257)">
    <!ENTITY charsetWinBaltic.accesskey "">
    <!ENTITY dcharMacRomCmd.label "Western (MacRoman)">
    <!ENTITY charsetMacRoman.accesskey "">
    <!ENTITY dcharMacCenEuroCmd.label "Central European (MacCE)">
    <!ENTITY charsetMacCentralEurope.accesskey "">
    <!ENTITY dcharMacTurCmd.label "Turkish (MacTurkish)">
    <!ENTITY charsetMacTurkish.accesskey "">
    <!ENTITY dcharMacCroaCmd.label "Croatian (MacCroatian)">
    <!ENTITY charsetMacCroatian.accesskey "">
    <!ENTITY dcharMacRomanianCmd.label "Romanian (MacRomanian)">
    <!ENTITY charsetMacRomanian.accesskey "">
    <!ENTITY dcharMacIceCmd.label "Icelandic (MacIcelandic)">
    <!ENTITY charsetMacIcelandic.accesskey "">
    <!ENTITY dcharJapanCmd.label "Japanese (ISO-2022-JP)">
    <!ENTITY charsetJIS.accesskey "">
    <!ENTITY dcharJapanShiftjsCmd.label "Japanese (Shift_JIS)">
    <!ENTITY charsetshiftJIS.accesskey "">
    <!ENTITY dcharJapanEucCmd.label "Japanese (EUC-JP)">
    <!ENTITY charsetJapaneseEUC.accesskey "">
    <!ENTITY dcharTradChiBigCmd.label "Chinese Traditional (Big5)">
    <!ENTITY charsetChineseBig5.accesskey "">
    <!ENTITY dcharTriChiEucCmd.label "Chinese Traditional (EUC-TW)">
    <!ENTITY charsetChineseEUC.accesskey "">
    <!ENTITY dcharSimpChiGbCmd.label "Chinese Simplified (GB2312)">
    <!ENTITY charsetChineseSimplified.accesskey "">
    <!ENTITY dcharKoreanCmd.label "Korean (EUC-KR)">
    <!ENTITY charsetKorean.accesskey "">
    <!ENTITY dcharUtf7Cmd.label "Unicode (UTF-7)">
    <!ENTITY charsetUTF7.accesskey "">
    <!ENTITY dcharUtf8Cmd.label "Unicode (UTF-8)">
    <!ENTITY charsetUTF8.accesskey "">
    <!ENTITY dcharIsoCyrCmd.label "Cyrillic (ISO-8859-5)">
    <!ENTITY charsetISOCyrillic.accesskey "">
    <!ENTITY dcharEcmaCyrCmd.label "Cyrillic (ISO-IR-111)">
    <!ENTITY charsetECMACyrillic.accesskey "">
    <!ENTITY dcharDosCyrCmd.label "Cyrillic (CP-866)">
    <!ENTITY charsetDOSCyrillic.accesskey "">
    <!ENTITY dcharWinCyrCmd.label "Cyrillic (Windows-1251)">
    <!ENTITY charsetWinCyrillic.accesskey "">
    <!ENTITY dcharMacCyrCmd.label "Cyrillic (MacCyrillic)">
    <!ENTITY charsetMacCyrillic.accesskey "">
    <!ENTITY dcharMacUkrCmd.label "Cyrillic/Ukrainian (MacUkrainian)">
    <!ENTITY charsetMacUkrainian.accesskey "">
    <!ENTITY dcharRusCmd.label "Cyrillic (KOI8-R)">
    <!ENTITY charsetRussian.accesskey "">
    <!ENTITY dcharUkrCmd.label "Cyrillic/Ukrainian (KOI8-U)">
    <!ENTITY charsetUkrainian.accesskey "">
    <!ENTITY dcharIsoGreekCmd.label "Greek (ISO-8859-7)">
    <!ENTITY charsetGreek.accesskey "">
    <!ENTITY dcharWinGreekCmd.label "Greek (Windows-1253)">
    <!ENTITY charsetWinGreek.accesskey "">
    <!ENTITY dcharMacGreekCmd.label "Greek (MacGreek)">
    <!ENTITY charsetMacGreek.accesskey "">
    <!ENTITY dcharWinVietCmd.label "Vietnamese (Windows-1258)">
    <!ENTITY charsetWinVietnamese.accesskey "">
    <!ENTITY dcharVietTcnCmd.label "Vietnamese (TCVN5712)">
    <!ENTITY charsetVietnameseTCN.accesskey "">
    <!ENTITY dcharVietViCmd.label "Vietnamese (VISCII)">
    <!ENTITY charsetVietnameseVIS.accesskey "">
    <!ENTITY dcharVieVpCmd.label "Vietnamese (VPS)">
    <!ENTITY charsetVietnameseVPS.accesskey "">
    <!ENTITY dcharThaiCmd.label "Thai (TIS-620)">
    <!ENTITY charsetThai.accesskey "">
    <!ENTITY dcharArmCmd.label "Armenian (ARMSCII-8)">
    <!ENTITY charsetArmenian.accesskey "">
    <!ENTITY dcharIso6Cmd.label ".Arabic (ISO-8859-6)">
    <!ENTITY charsetArabic.accesskey "">
    <!ENTITY dcharIso8Cmd.label ".Hebrew (ISO-8859-8)">
    <!ENTITY charsetHebrew.accesskey "">
    <!ENTITY dcharCp1255Cmd.label "Hebrew (Windows-1255)">
    <!ENTITY charsetWinHebrew.accesskey "">
    <!ENTITY dcharCp1256Cmd.label "Arabic (Windows-1256)">
    <!ENTITY charsetWinArabic.accesskey "">
    ...

Updated

16 years ago
Keywords: intl
QA Contact: ruixu → ylong

Comment 1

16 years ago
Is it better to remove both files or just have them as blank?
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0.1
(Reporter)

Comment 2

16 years ago
There are other lines that I assume are still being used.
We just need to delete the obsolete lines.

Comment 3

16 years ago
Can someone tell me exactly which lines we need to remove?
tao, rchen?

Comment 4

16 years ago
Should be Naoki?
(Reporter)

Comment 5

16 years ago
> Can someone tell me exactly which lines we need to remove?

They are listed in bug description.
(Assignee)

Comment 6

16 years ago
Created attachment 81799 [details] [diff] [review]
Remove unused string for charset menu.
(Assignee)

Comment 7

16 years ago
Reassign to nhotta.

Ray, could you review the patch?
Assignee: yokoyama → nhotta
Status: ASSIGNED → NEW

Comment 8

16 years ago
Comment on attachment 81799 [details] [diff] [review]
Remove unused string for charset menu.

r=ftang, I search the net, see no other places use them.
Attachment #81799 - Flags: review+
(Assignee)

Updated

16 years ago
Status: NEW → ASSIGNED

Comment 9

16 years ago
Comment on attachment 81799 [details] [diff] [review]
Remove unused string for charset menu.

sr=alecf
Attachment #81799 - Flags: superreview+
(Assignee)

Comment 10

16 years ago
checked in to the trunk

Ray, is this needed for the branch?
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 11

16 years ago
Yes, but not for the beta release.
You need to log in before you can comment on or make changes to this bug.