1401223 - [RTL] Part of the top bar of the hamburger button is missing when an update is available

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Itiel]

Attachment: Top bar missing

This started about 3 days ago.
When an update is available, and the green arrow appears on top of the hamburger button, the right part of the top bar is missing.
Happpens only on RTL, working okay on LTR.

See attached.

Comment 1

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Uuugly UI regression on RTL requiring 0 user interaction.



I uh, I guess we should invert the badged icon on RTL now that it's no longer right/left symmetric. I should have thought of that in review. :-(

Doug, do you have cycles to create the relevant CSS patch?

Comment 2

[Alex Thayer [:alexical] (she/her)]

On it.

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1401223 - Flip badged menu icon direction under rtl

When it's badged, the icon is no longer symmetrical. Since it's
a list-style-image, which doesn't lend itself to an easy scaleX(-1),
making a new svg seemed the simpler option.

Review commit: https://reviewboard.mozilla.org/r/181810/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181810/

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187194

::: browser/themes/shared/toolbarbutton-icons.inc.css:27
(Diff revision 1)
>  #forward-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #reload-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #nav-bar-overflow-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #PlacesChevron:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #panic-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
>    transform: scaleX(-1);

Can you just add your selector to this rule?

Comment 5

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181810/diff/1-2/

Comment 6

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187194

> Can you just add your selector to this rule?

Woops. Yup

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187200

::: browser/themes/shared/toolbarbutton-icons.inc.css:29
(Diff revision 2)
>  #nav-bar-overflow-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #PlacesChevron:-moz-locale-dir(rtl) > .toolbarbutton-icon,
> -#panic-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
> +#panic-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
> +#PanelUI-menu-button[badge-status="update-available"]:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon,
> +#PanelUI-menu-button[badge-status="update-manual"]:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon,
> +#PanelUI-menu-button[badge-status="update-restart"]:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon {

How about just mirroring #PanelUI-menu-button:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon regardless of [bad-status]?

Comment 8

[Alex Thayer [:alexical] (she/her)]

Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181810/diff/2-3/

Comment 9

[:Gijs (he/him)]

Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187212

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6fae3d9c774a
Flip badged menu icon direction under rtl r=Gijs

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6fae3d9c774a

Comment 12

[Itiel]

Fixed on latest Nightly.