Closed Bug 1401223 Opened 2 years ago Closed 2 years ago

[RTL] Part of the top bar of the hamburger button is missing when an update is available

Categories

(Firefox :: Theme, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 57
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 + verified

People

(Reporter: itiel_yn8, Assigned: dthayer)

References

Details

(Keywords: regression, rtl)

Attachments

(2 files)

Attached image Top bar missing
This started about 3 days ago.
When an update is available, and the green arrow appears on top of the hamburger button, the right part of the top bar is missing.
Happpens only on RTL, working okay on LTR.

See attached.
[Tracking Requested - why for this release]:
Uuugly UI regression on RTL requiring 0 user interaction.



I uh, I guess we should invert the badged icon on RTL now that it's no longer right/left symmetric. I should have thought of that in review. :-(

Doug, do you have cycles to create the relevant CSS patch?
Blocks: 1380345
Flags: needinfo?(dothayer)
Keywords: regression
On it.
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Flags: needinfo?(dothayer)
Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187194

::: browser/themes/shared/toolbarbutton-icons.inc.css:27
(Diff revision 1)
>  #forward-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #reload-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #nav-bar-overflow-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #PlacesChevron:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #panic-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
>    transform: scaleX(-1);

Can you just add your selector to this rule?
Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187194

> Can you just add your selector to this rule?

Woops. Yup
Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187200

::: browser/themes/shared/toolbarbutton-icons.inc.css:29
(Diff revision 2)
>  #nav-bar-overflow-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
>  #PlacesChevron:-moz-locale-dir(rtl) > .toolbarbutton-icon,
> -#panic-button:-moz-locale-dir(rtl) > .toolbarbutton-icon {
> +#panic-button:-moz-locale-dir(rtl) > .toolbarbutton-icon,
> +#PanelUI-menu-button[badge-status="update-available"]:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon,
> +#PanelUI-menu-button[badge-status="update-manual"]:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon,
> +#PanelUI-menu-button[badge-status="update-restart"]:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon {

How about just mirroring #PanelUI-menu-button:-moz-locale-dir(rtl) > .toolbarbutton-badge-stack > .toolbarbutton-icon regardless of [bad-status]?
Comment on attachment 8910349 [details]
Bug 1401223 - Flip badged menu icon direction under rtl

https://reviewboard.mozilla.org/r/181810/#review187212
Attachment #8910349 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6fae3d9c774a
Flip badged menu icon direction under rtl r=Gijs
https://hg.mozilla.org/mozilla-central/rev/6fae3d9c774a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Fixed on latest Nightly.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.