Closed Bug 1401292 Opened 2 years ago Closed 2 years ago

Remove the left margin of some elements in the in-content Preferences

Categories

(Thunderbird :: Preferences, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 57.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Some descriptions and buttons aren't correctly left aligned in the in-content prefs.
Attached patch noLeftMargin.patch (obsolete) — Splinter Review
No need for a m-c tip.

This fixes the descriptions/labels which aren't in a groupbox. There are also some buttons/menulists which aren't aligned.

In Composition > General the first line looks a bit condensed (gap between menulist and checkbox and between line one and two). I added for this a <separator> to give some spacing.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8909920 - Flags: review?(jorgk)
Comment on attachment 8909920 [details] [diff] [review]
noLeftMargin.patch

Review of attachment 8909920 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: mail/themes/shared/mail/incontentprefs/aboutPreferences.css
@@ +273,5 @@
>  #crashReporterLearnMore {
>    margin-inline-end: 4px !important;
>  }
>  
> +/* Remove the start margin to align this elements */

these
Attachment #8909920 - Flags: review?(jorgk) → review+
Changed this to these.
Attachment #8909920 - Attachment is obsolete: true
Attachment #8910352 - Flags: review+
Keywords: checkin-needed
(In reply to Richard Marti (:Paenglab) from comment #3)
> Changed this to these.
You made it worse :-(
/* Remove these start margin to align this elements */
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/ca69e3921804
Remove the left margin of some elements in the in-content preferences. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 57.0
You need to log in before you can comment on or make changes to this bug.