Wrong key value type for display mode setting

RESOLVED FIXED in Firefox 57

Status

enhancement
RESOLVED FIXED
2 years ago
8 months ago

People

(Reporter: esawin, Assigned: esawin)

Tracking

51 Branch
mozilla57
All
Android

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(1 attachment)

Display mode should be an integer setting.
Comment on attachment 8909949 [details] [diff] [review]
0001-Bug-1401313-1.0-Change-display-mode-key-value-type-t.patch

Review of attachment 8909949 [details] [diff] [review]:
-----------------------------------------------------------------

Wow, how did this ever work?
Attachment #8909949 - Flags: review?(snorp) → review+
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #2)
> Wow, how did this ever work?

getInt/setInt is handling the correct value type (int) but expects the wrong key type (Key<Boolean>) which is consistent with the wrongly typed display mode setting.
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/297d002e2bba
[1.0] Change display mode key value type to integer. r=snorp
https://hg.mozilla.org/mozilla-central/rev/297d002e2bba
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 57 → mozilla57
You need to log in before you can comment on or make changes to this bug.