Closed
Bug 1401313
Opened 8 years ago
Closed 8 years ago
Wrong key value type for display mode setting
Categories
(GeckoView :: IME, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: esawin, Assigned: esawin)
Details
Attachments
(1 file)
|
2.02 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
Display mode should be an integer setting.
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8909949 -
Flags: review?(snorp)
Comment on attachment 8909949 [details] [diff] [review]
0001-Bug-1401313-1.0-Change-display-mode-key-value-type-t.patch
Review of attachment 8909949 [details] [diff] [review]:
-----------------------------------------------------------------
Wow, how did this ever work?
Attachment #8909949 -
Flags: review?(snorp) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #2)
> Wow, how did this ever work?
getInt/setInt is handling the correct value type (int) but expects the wrong key type (Key<Boolean>) which is consistent with the wrongly typed display mode setting.
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/297d002e2bba
[1.0] Change display mode key value type to integer. r=snorp
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
|
||
Updated•7 years ago
|
Product: Firefox for Android → GeckoView
|
||
Updated•7 years ago
|
Target Milestone: Firefox 57 → mozilla57
|
||
Comment 6•3 years ago
|
||
Moving some cursor and key event bugs to the new GeckoView::IME component.
Component: General → IME
You need to log in
before you can comment on or make changes to this bug.
Description
•