Closed Bug 1401314 Opened 2 years ago Closed 2 years ago

The search screenshots in the preferences window are wrong in RTL mode

Categories

(Firefox :: Preferences, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox-esr52 --- unaffected
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 + fixed
firefox58 --- fixed

People

(Reporter: ehsan, Assigned: jaws)

References

Details

(Keywords: rtl, Whiteboard: [reserve-photon-preference])

Attachments

(1 file)

[Tracking Requested - why for this release]: This release first introduces this UI.

They need to be flipped properly, they currently show an LTR browser UI.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [reserve-photon-preference]
Comment on attachment 8911177 [details]
Bug 1401314 - Flip the search box images in the preferences when Firefox is running in RTL mode.

https://reviewboard.mozilla.org/r/182678/#review187986

::: browser/themes/shared/incontentprefs/search.css:24
(Diff revision 1)
> +.searchBarHiddenImage:-moz-locale-dir(rtl),
> +.searchBarShownImage:-moz-locale-dir(rtl) {

You can use `.searchBarImage:-moz-locale-dir(rtl)` instead of selecting the 2 images separately. :-)
Attachment #8911177 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d7d8c8e2f08e
Flip the search box images in the preferences when Firefox is running in RTL mode. r=Gijs
Comment on attachment 8911177 [details]
Bug 1401314 - Flip the search box images in the preferences when Firefox is running in RTL mode.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1393437 
[User impact if declined]: users in RTL will see backwards-looking screenshot in preferences
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no, manually verified locally
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: simple CSS addition to flip the image if the browser is in RTL mode
[String changes made/needed]: none
Attachment #8911177 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/d7d8c8e2f08e
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8911177 [details]
Bug 1401314 - Flip the search box images in the preferences when Firefox is running in RTL mode.

Fix a RTL issue, taking it.
Should be in 57b4 (gtb tomorrow Thursday)
Attachment #8911177 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #5)
> [Is this code covered by automated tests?]: no
> [Has the fix been verified in Nightly?]: no, manually verified locally
> [Needs manual test from QE? If yes, steps to reproduce]: no

Setting qe-verify- based on Jared's assessment on manual testing needs.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.