1401324 - when loading a temporary add-on the last folder should be remembered

Status: RESOLVED FIXED

(DevTools :: about:debugging, defect, P1)

Description

[kernp25]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170919100405

Steps to reproduce:

1. Go to about:debugging
2. Click the "Load Temporary Add-on" button and select a WebExtension
3. Restart the browser


Actual results:

I have to navigate everytime to the folder to load the add-on. (default is downloads folder)


Expected results:

It should remember the last folder where the add-on was loaded.

Comment 1

[Andy McKay]

I generally find web-ext more convenient for this.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This is really annoying bug to me. It does not make sense to share the default folder of file picker with last download folder...

Why don't you put the last folder into new pref here:
https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging-new/src/modules/extensions-helper.js#102-138
and set fp.displayDirectory to the nsIFile instance created with the pref value?

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1401324 - Remember last folder used to load a temporary extension

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1401324 - Add mochitest for remembering temporary addon folder;

Depends on D29141

Comment 6

[Julian Descottes [:jdescottes]]

try push with the tests suggested by Daisuke: https://treeherder.mozilla.org/#/jobs?repo=try&revision=081b6e181d774eea0bdb5ffa03f5b18a507cafe7

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ecc1127396f9
Remember last folder used to load a temporary extension r=daisuke
https://hg.mozilla.org/integration/autoland/rev/1f27cacfb9cf
Add mochitest for remembering temporary addon folder; r=daisuke

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ecc1127396f9
https://hg.mozilla.org/mozilla-central/rev/1f27cacfb9cf