1401346 - Move browser/base/content/illustrations to browser/themes/shared

Status: RESOLVED FIXED

(Firefox :: General, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

I overlooked this in my review of bug 1394460, I think browser/themes is a better place for these illustrations, so we should update that at some point.

Comment 1

[Manish [:manishkk]]

Attachment: Bug 1401346- Move browser/base/content/illustrations to browser/themes/shared

Comment 2

[Manish [:manishkk]]

I should remove these lines from here: https://searchfox.org/mozilla-central/source/browser/base/jar.mn#17-21

and I should add these images with new path here: https://searchfox.org/mozilla-central/source/browser/themes/shared/jar.inc.mn#63

Comment 3

[Johann Hofmann [:johannh]]

That sounds right to me, yes.

Comment 4

[shwetaagra28]

I would like to work on this bug.Please assign it to me.

Comment 5

[Johann Hofmann [:johannh]]

Thanks!

Comment 6

[shwetaagra28]

I moved 5 svg type files from browser/base/content/illustrations to browser/themes/shared/illustrations
I also updated jar.mn file
https://searchfox.org/mozilla-central/source/browser/base/jar.mn#18-22
I updated the above lines to
content/browser/illustrations/error-connection-failure.svg (../themes/shared/illustrations/error-connection-failure.svg)
content/browser/illustrations/error-server-not-found.svg (../themes/shared/illustrations/error-server-not-found.svg)
content/browser/illustrations/error-malformed-url.svg (../themes/shared/illustrations/error-malformed-url.svg)
content/browser/illustrations/under-construction.svg (../themes/shared/illustrations/under-construction.svg)
content/browser/illustrations/blue-berror.svg (../themes/shared/illustrations/blue-berror.svg)?

Is it the right way to fix this bug.The build is successful after doing this changes.But I dont know which file path to mention while doing ./mach test

Comment 7

[shwetaagra28]

(In reply to shwetaagra28 from comment #6)

I moved 5 svg type files from browser/base/content/illustrations to browser/themes/shared/illustrations
I also updated jar.mn file
https://searchfox.org/mozilla-central/source/browser/base/jar.mn#18-22
I updated the above lines to
content/browser/illustrations/error-connection-failure.svg (../themes/shared/illustrations/error-connection-failure.svg)
content/browser/illustrations/error-server-not-found.svg (../themes/shared/illustrations/error-server-not-found.svg)
content/browser/illustrations/error-malformed-url.svg (../themes/shared/illustrations/error-malformed-url.svg)
content/browser/illustrations/under-construction.svg (../themes/shared/illustrations/under-construction.svg)
content/browser/illustrations/blue-berror.svg (../themes/shared/illustrations/blue-berror.svg)?

Is it the right way to fix this bug.The build is successful after doing this changes.But I dont know which file path to mention while doing ./mach test

Comment 8

[shwetaagra28]

(In reply to shwetaagra28 from comment #7)

(In reply to shwetaagra28 from comment #6)

I moved 5 svg type files from browser/base/content/illustrations to browser/themes/shared/illustrations
I also updated jar.mn file
https://searchfox.org/mozilla-central/source/browser/base/jar.mn#18-22
I updated the above lines to
content/browser/illustrations/error-connection-failure.svg (../themes/shared/illustrations/error-connection-failure.svg)
content/browser/illustrations/error-server-not-found.svg (../themes/shared/illustrations/error-server-not-found.svg)
content/browser/illustrations/error-malformed-url.svg (../themes/shared/illustrations/error-malformed-url.svg)
content/browser/illustrations/under-construction.svg (../themes/shared/illustrations/under-construction.svg)
content/browser/illustrations/blue-berror.svg (../themes/shared/illustrations/blue-berror.svg)?

Is it the right way to fix this bug.The build is successful after doing this changes.But I dont know which file path to mention while doing ./mach test

Comment 9

[Johann Hofmann [:johannh]]

Yeah I don't think this can be really tested, but your description sounds correct. If you make a patch I can review it :)

(I assume you closed this by accident)

Comment 10

[shwetaagra28]

I am sorry I closed it by accident.Thankyou for reopening it and also for your response. I'll make the patch asap.

Comment 11

[shwetaagra28]

Attachment: Bug 1401346 - Move browser/base/content/illustrations to browser/themes/shared. r=johannh

Depends on D66390

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cf8097e0027
Move browser/base/content/illustrations to browser/themes/shared. r=johannh

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0cf8097e0027