Closed Bug 1401354 Opened 2 years ago Closed 2 years ago

GeckoView example app fails to load page after startup

Categories

(GeckoView :: General, defect)

51 Branch
All
Android
defect
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: esawin, Assigned: esawin)

References

Details

Attachments

(4 files, 1 obsolete file)

Bug 1396065 has introduced URI load delegation but failed to account for the case where no navigation listener is set.
Don't handle URI load delegations if there is no navigation listener set.
Attachment #8909999 - Flags: review?(snorp)
Set the navigation listener for the example app. Seems like we have inconsistent names for our example listener implementations (I vote for dropping the MyGeckoView prefix or reduce it to just My).
Attachment #8910000 - Flags: review?(snorp)
Attachment #8909999 - Attachment is obsolete: true
Attachment #8909999 - Flags: review?(snorp)
Attachment #8910334 - Flags: review?(snorp)
We don't seem to load and set the GeckoView settings from new intents if no intent data (URL) is provided.
Attachment #8910351 - Flags: review?(snorp)
Attachment #8910000 - Flags: review?(snorp) → review+
Attachment #8910333 - Flags: review?(snorp) → review+
Attachment #8910334 - Flags: review?(snorp) → review+
Attachment #8910351 - Flags: review?(snorp) → review+
Pushed by esawin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f4239905d5db
[1.1] Only delegate URI loads if a navigation listener is set. r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b7e8ce842b3
[2.0] Set navigation listener for geckoview_example. r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/aaf18a43b559
[3.0] Track registration state in GeckoView modules. r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/6df15cf80b6b
[4.0] Always load settings from intent extra in geckoview_example. r=snorp
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 58 → mozilla58
You need to log in before you can comment on or make changes to this bug.