1401359 - Disable SharedWorker in contexts where storage is not available

Status: RESOLVED FIXED

(Core :: DOM: Workers, enhancement, P2)

Description

[Ben Kelly [:bkelly, not reviewing]]

There are a number of cases where we disable storage in a window.  For example, in 3rd party iframes when 3rd party cookies are disabled, etc.  If one of these windows attaches to a SharedWorker it could gain access to storage in the worker context or another non-restricted window attached to the same worker.

To mitigate this we should disable SharedWorker when storage is disabled.  Its better to be overly restrictive here since we can loosen the restrictions later.

Comment 1

[Anne (:annevk)]

Do we have an open bug on using double-keying instead for all of these APIs? That would presumably lead to less breakage and would increase parity with Safari.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Anne (:annevk) from comment #1)
> Do we have an open bug on using double-keying instead for all of these APIs?
> That would presumably lead to less breakage and would increase parity with
> Safari.

We have work-in-progress on "first party isolation" which is what I believe our double-keying solution is called.  I don't know where we stand on being able to make it the default, though.  Its a bigger job than restricting some known problematic APIs right now.

Comment 3

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Disable SharedWorker if in windows that cannot access storage. r=baku

This patch disables SharedWorker for now in windows that cannot access storage.  This is a bit heavy handed since there are some cases where its safe.  For example, if all storage is disabled then using SharedWorker should be fine.  For now, though, lets close the loop-hole that lets 3rd party iframes escape to other windows via the SharedWorker.  We can relax this later if necessary.

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1bab8d2defe112843775f15f3fe99c0d0eede1f

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8910468 [details] [diff] [review]
Disable SharedWorker if in windows that cannot access storage. r=baku

Hmm, this breaks SharedWorker in private browsing mode which we explicitly verify works right now.

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Disable SharedWorker if in windows that cannot access storage. r=baku

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0c8012a2a7559e81612a1e6190ff80941597dc1e

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8936462 [details] [diff] [review]
Disable SharedWorker if in windows that cannot access storage. r=baku

Andrea, this patch disabled SharedWorker in contexts that cannot access storage.  It does allow it for private browsing, however, because we purposely isolate SharedWorker by private browsing session ID already.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/950d56123c67
Disable SharedWorker if in windows that cannot access storage. r=baku

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/950d56123c67