1401382 - TPS should wait for formautofill tests to complete.

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Thom Chiovoloni [:tcsc] (ex-moco)]

Reported by eoger in IRC. This isn't the cause of the latest failing TPS test (which seems to be the same as the previous one... :(). I've also fixed this for history, which is marked as async but not awaited (since all the operations in it are synchronous, this isn't a problem yet).

Comment 1

[Thom Chiovoloni [:tcsc] (ex-moco)]

Attachment: Bug 1401382 - Make it safe to await inside async TPS handlers

This patch also makes all the remaining synchronouns TPS handlers async, since
it seems likely that this issue could happen again.

Review commit: https://reviewboard.mozilla.org/r/181488/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181488/

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8910012 [details]
Bug 1401382 - Make it safe to await inside async TPS handlers

https://reviewboard.mozilla.org/r/181488/#review186804

::: services/sync/tps/extensions/tps/resource/tps.jsm:403
(Diff revision 1)
>        }
>      }
>      Logger.logPass("executing action " + action.toUpperCase() +
>                     " on formdata");
> -  },
> -
> +async   
> +  await async HandleHistory(entries, action) {

I suspect this isn't what you intended?

Comment 3

[Thom Chiovoloni [:tcsc] (ex-moco)]

Comment on attachment 8910012 [details]
Bug 1401382 - Make it safe to await inside async TPS handlers

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/181488/diff/1-2/

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8910012 [details]
Bug 1401382 - Make it safe to await inside async TPS handlers

https://reviewboard.mozilla.org/r/181488/#review186816

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d37fb0f952b
Make it safe to await inside async TPS handlers r=markh

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1d37fb0f952b