Closed Bug 1401394 Opened 2 years ago Closed 2 years ago
Update icon in add-ons menu only appears in phone configuration
59 bytes, text/x-review-board-request
Originally implemented in bug 1391579. I spoke with aswan and this should also work for tablet configs. I'm going to write the patch and aswan is going to test it.
NI :aswan to test or STR.
Michael, the setup I use for testing updates is here: https://github.com/aswan/update-test If it isn't clear or if it doesn't work for you, let me know and I'll try to test here...
2 years ago
Summary: gecko:itemType="icon_menu_item" only specified in phone configuration → Update icon in add-ons menu only appears in phone configuration
I verified: - Following the STR on a Nexus 5 (phone) displays the update add-on icon in the 3-dot menu - Following the STR without my patch on a Nexus 7 (large tablet) *does not* display the update add-on icon in the 3-dot menu - Following the STR with my patch on a Nexus 7 (large tablet) *does* display the update add-on icon in the 3-dot menu So working as expected. A more thorough test would also verify: - xlarge tablets - Android O But I think with a thorough code review, we can trust this works as expected.
Comment on attachment 8910034 [details] Bug 1401394: Add missing gecko:itemType to non-phone configurations. https://reviewboard.mozilla.org/r/181508/#review187254 Thanks for adding a more descriptive title, there was no explanation of what was broken or what was supposed to be fixed. Seems fine to me.
Attachment #8910034 - Flags: review?(liuche) → review+
NI self to verify this hits 57.
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/b5be4a3d9f13 Add missing gecko:itemType to non-phone configurations. r=liuche
(In reply to Michael Comella (:mcomella) from comment #6) > NI self to verify this hits 57. Done.
You need to log in before you can comment on or make changes to this bug.