1401394 - Update icon in add-ons menu only appears in phone configuration

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Add-on Manager, enhancement)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Originally implemented in bug 1391579.

I spoke with aswan and this should also work for tablet configs.

I'm going to write the patch and aswan is going to test it.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1401394: Add missing gecko:itemType to non-phone configurations.

I don't know the greater context of this code and if this will cause any problems: I'm just following the patterns in Android menus to fix this code.

:aswan is expected to test this patch for me (or provide me steps to test
whether or not it's working correctly).

Review commit: https://reviewboard.mozilla.org/r/181508/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181508/

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

NI :aswan to test or STR.

Comment 3

[Andrew Swan [:aswan]]

Michael, the setup I use for testing updates is here:
https://github.com/aswan/update-test

If it isn't clear or if it doesn't work for you, let me know and I'll try to test here...

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I verified:
- Following the STR on a Nexus 5 (phone) displays the update add-on icon in the 3-dot menu
- Following the STR without my patch on a Nexus 7 (large tablet) *does not* display the update add-on icon in the 3-dot menu
- Following the STR with my patch on a Nexus 7 (large tablet) *does* display the update add-on icon in the 3-dot menu

So working as expected.

A more thorough test would also verify:
- xlarge tablets
- Android O

But I think with a thorough code review, we can trust this works as expected.

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8910034 [details]
Bug 1401394: Add missing gecko:itemType to non-phone configurations.

https://reviewboard.mozilla.org/r/181508/#review187254

Thanks for adding a more descriptive title, there was no explanation of what was broken or what was supposed to be fixed. 

Seems fine to me.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

NI self to verify this hits 57.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5be4a3d9f13
Add missing gecko:itemType to non-phone configurations. r=liuche

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b5be4a3d9f13

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #6)
> NI self to verify this hits 57.

Done.