1401412 - Objects destroyed too late in shutdown

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Blake Kaplan (:mrbkap) (inactive)]

When my content processes shutdown, I get:

  [Child 3738, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /home/mrbkap/work/main/mozilla/xpcom/base/nsTraceRefcnt.cpp, line 171

using a debugger, this turns out to be the InputEventStatistics object [1]. It uses a static singleton which is only torn down after everything else is torn down. We should avoid doing that.

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1401412 - Destroy this singleton during XPCOM shutdown.

Unfortunately, this needed some additional trickery in order to keep its
constructor "private". I stole this trick from [1]. With this patch, we tear
down the statistics object during XPCOM shutdown intead of after it. I don't
believe that we need the object to live past the ClearOnShutdown destructors.

[1] http://rienajouter.blogspot.com/2014/10/makeshared-and-makeunique-for-classes.html

Review commit: https://reviewboard.mozilla.org/r/181530/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181530/

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8910056 [details]
Bug 1401412 - Destroy this singleton during XPCOM shutdown.

https://reviewboard.mozilla.org/r/181530/#review187026

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a44548cb570
Destroy this singleton during XPCOM shutdown. r=smaug

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5a44548cb570