Closed Bug 1401463 Opened 2 years ago Closed 2 years ago

Remember previous URL in "reset password" state

Categories

(bugzilla.mozilla.org :: General, enhancement)

Production
enhancement
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dylan)

Details

Attachments

(1 file)

45 bytes, text/x-github-pull-request
dylan
: review+
Details | Review
Today, one of my machines had lost its bugzilla logged-in status.  And when I logged in, I found that my account was in a "you must reset your bugzilla password" state.

Unfortunately: while I was in this state [i.e. until I relented and completed the form by deciding on a new password], *all bugzilla pages* (including e.g. https://bugzilla.mozilla.org/show_bug.cgi?id=1401416 or other arbitrary public bug pages) would be forcibly redirected to https://bugzilla.mozilla.org/reset_password.cgi , the password-reset page.

This is quite problematic -- it meant any previously-bugzilla tab that I viewed/ (or perhaps that I reloaded -- I'm not sure) would *lose its URL* and lose track of whatever bug it had previously been viewing.

I (and other mozilla developers) tend to maintain an informal "to-do" / "bugs-to-check-back-on" list, via our list of open tabs.  So, bugzilla's force-redirect behavior here ended up effectively destroying some items from my to-do list, by redirecting them away from the bugs they'd previously been viewing. :(

Can we adjust the password-reset flow so that it doesn't trigger this?
Summary: In bugzilla "you must reset password" state, all bug pages are force-redirected to password reset page, which loses "to-do" information that I have encoded in open tabs → In bugzilla "you must reset password" state, all bug pages are force-redirected to password reset page, which loses "to-do" information that I have encoded as open tabs viewing particular bug pages
We can preserve the URL I think.
Assignee: nobody → dylan
Attached file WIP PR
My attempt at securely redirecting urls is failing, probably because my brain is mush
Comment on attachment 8911388 [details] [review]
WIP PR

r=seban
Attachment #8911388 - Flags: review+
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Summary: In bugzilla "you must reset password" state, all bug pages are force-redirected to password reset page, which loses "to-do" information that I have encoded as open tabs viewing particular bug pages → Remember previous URL in "reset password" state
You need to log in before you can comment on or make changes to this bug.