140149 - Disable cookies pref for MailNews disappears on 2nd app launch (MAC OS X ONLY).

Status: VERIFIED FIXED

(MailNews Core :: Security, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

Build ID: 2002-04-25-08 Trunk Mozilla, Mac OS X 10.1.4

Summary: Disable cookies pref for Mailnews disappears on 2nd app launch (MAC ONLY).

This is _so_ strange, but here goes:

Steps to Reproduce:

After deleting both the Documents:Mozilla folder on OS X and my profile, then
running Mozilla, the 1st time I've launched the build, the preference 'Disable
cookies in Mail & Newsgroups' and the checkbox are both existent.

However, the 2nd time I launch the app, that whole pref just disappears from the
UI.  The pref isn't gone - it still exists in all.js.

For some reason, this JS routine is failing to find out if we have Mail
installed on Mac OS X 10.1.3 and Mac OS 9.2.2

pref-cookies.xul:

+    // if mailnews is installed then we will have
networkCookieBehaviorForMailNews checkbox
+    if (document.getElementById('networkDisableCookieForMailNews'))
+    {
+      var networkDisableCookieForMailNews =
document.getElementById("networkDisableCookieForMailNews");
+      networkDisableCookieForMailNews.disabled = cookieBehavior.value ==
cookies_disabled; 
+    }

I'm also wondering if there is some mac-centricness going on with:

mailPrefsOverlay.xul

where once we've gotten the pref's state, we insert this into the UI:

+  <page id="cookiesPanel">
+    <checkbox id="networkDisableCookieForMailNews"
+              label="&disableCookieForMailNews.label;"
accesskey="&disableCookieForMailNews.accesskey;"
+              pref="true" preftype="bool"
prefstring="network.cookie.disableCookieForMailNews"
+              prefattribute="checked"
insertafter="networkCookieBehaviorSeparator"/>
+  </page>

Sorry to ramble/guess - here's the full patch:

http://bugzilla.mozilla.org/showattachment.cgi?attach_id=78375

Comment 1

[[e-mail] (gone - use [e-mail] instead)]

Over to Navin who implemented this feature. 

Comment 2

[Navin Gupta]

Is this just MAC OSX or Mac OS 9 also ?

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

From comment 1 - 

For some reason, this JS routine is failing to find out if we have Mail
installed on Mac OS X 10.1.3 and Mac OS 9.2.2

Both.

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

er...comment 0 ;-)

Comment 5

[scottputterman]

nsbeta1+ per mail triage.  Is this happening on the branch using an NS build? 
If not, please remove the nsbeta1+ and adt markings.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Yes, still occuring with the 5-17 Mozilla1.0.0 Commercial Branch build on OS X
10.1.4.

Comment 7

[Navin Gupta]

Attachment: proposed fix

This patch fixes the problem on MAC OS X commercial. I think it is because pref
by default is false on commerical build and MAC does not like this(it seems).

Comment 8

[Navin Gupta]

cavin, can I get a review, thx.

Comment 9

[Navin Gupta]

bhuvan, can I get r=? thx

Comment 10

[racham]

Comment on attachment 84687 [details] [diff] [review]
proposed fix

r=bhuvan

Comment 11

[Scott MacGregor]

Comment on attachment 84687 [details] [diff] [review]
proposed fix

sr=mscott

Comment 12

[Navin Gupta]

fixed on trunk

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

Sorry, this still isn't fixed on trunk builds:

Mac OS 9.2.2 - 2002-05-24-03
Mac OS X 10.1.4 - 2002-05-24-08

In fact, I no longer ever see the pref, as opposed to seeing it manifest the 1st
time, then disappear upon app relaunch.

Re-opening.

Comment 14

[scottputterman]

removing the nomination since it isn't fixed on the trunk.

Comment 15

[Navin Gupta]

This is fixed on mac os 9.x. I will have to try MAC OS X. 

Comment 16

[[e-mail] (gone - use [e-mail] instead)]

Only on the trunk - on the branch, OS 9.2.2 displays this pref the 1st time, but
on relaunch it disappears, as well.  Sigh.

Comment 17

[Navin Gupta]

This fix was never checked on the branch.

Comment 18

[[e-mail] (gone - use [e-mail] instead)]

ah, yes, right!  good thing it works now on OS 9.2.2 then.

Comment 19

[scottputterman]

It sounds like this actually works on the trunk, so I think this can marked
verified.  Nominating for branch.

Comment 20

[[e-mail] (gone - use [e-mail] instead)]

Indeed it is, I'll now mark it as such.  What happened to make this work all of
a sudden?

Comment 21

[[e-mail] (gone - use [e-mail] instead)]

Verified on trunk with build:

2002-06-05-08, Mac OS X 10.1.5

Comment 22

[scottputterman]

adding adt1.0.1+.  Please get drivers approval before checking into the branch.

Comment 23

[scottputterman]

Navin, can you check this in ASAP to the branch.

Comment 24

[Navin Gupta]

The branch is currently closed. I'll check it in, once it reopens.

Comment 25

[Navin Gupta]

fixed on branch.

Comment 26

[[e-mail] (gone - use [e-mail] instead)]

Verified FIXED with:

Mozilla/5.0 (Macintosh; U; PPC Mac OS X; en-US; rv:1.0.0) Gecko/20020613
Netscape/7.0b1

on Mac OS X 10.1.5