1401497 - menu-badged.svg lacks context-fill-opacity

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

menu-badged.svg has fill="context-fill" but lacks fill-opacity="context-fill-opacity", which likely leads to an inconsistent icon color when the badge is present.

Comment 1

[Dão Gottwald [:dao]]

Doug, can you take a look? Thanks.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1401497 - Give menu-badged.svg context-fill-opacity

This was missing from copy of menu.svg.

Review commit: https://reviewboard.mozilla.org/r/182682/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182682/

Comment 3

[Alex Thayer [:alexical] (she/her)]

Woops. Missed that somehow.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 8911182 [details]
Bug 1401497 - Give menu-badged.svg context-fill-opacity

https://reviewboard.mozilla.org/r/182682/#review187952

Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c739418cacc4
Give menu-badged.svg context-fill-opacity r=dao

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c739418cacc4

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 8911182 [details]
Bug 1401497 - Give menu-badged.svg context-fill-opacity

Approval Request Comment
[Feature/Bug causing the regression]: bug 1380345
[User impact if declined]: menu button color might be off when the button has a badge
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]:
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: no
[Why is the change risky/not risky?]: only adding fill-opacity="context-fill-opacity" in the svg
[String changes made/needed]: /

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8911182 [details]
Bug 1401497 - Give menu-badged.svg context-fill-opacity

Consistency, taking it.
Should be in 57b3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/13011edd1ef4