Closed Bug 1401497 Opened 8 years ago Closed 8 years ago

menu-badged.svg lacks context-fill-opacity

Categories

(Firefox :: Theme, defect)

57 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 58
Tracking Status
firefox57 --- fixed
firefox58 --- fixed

People

(Reporter: dao, Assigned: alexical)

References

Details

Attachments

(1 file)

menu-badged.svg has fill="context-fill" but lacks fill-opacity="context-fill-opacity", which likely leads to an inconsistent icon color when the badge is present.
Doug, can you take a look? Thanks.
Flags: needinfo?(dothayer)
Woops. Missed that somehow.
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Flags: needinfo?(dothayer)
Comment on attachment 8911182 [details] Bug 1401497 - Give menu-badged.svg context-fill-opacity https://reviewboard.mozilla.org/r/182682/#review187952 Thanks!
Attachment #8911182 - Flags: review?(dao+bmo) → review+
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c739418cacc4 Give menu-badged.svg context-fill-opacity r=dao
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8911182 [details] Bug 1401497 - Give menu-badged.svg context-fill-opacity Approval Request Comment [Feature/Bug causing the regression]: bug 1380345 [User impact if declined]: menu button color might be off when the button has a badge [Is this code covered by automated tests?]: no [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: [List of other uplifts needed for the feature/fix]: / [Is the change risky?]: no [Why is the change risky/not risky?]: only adding fill-opacity="context-fill-opacity" in the svg [String changes made/needed]: /
Attachment #8911182 - Flags: approval-mozilla-beta?
Comment on attachment 8911182 [details] Bug 1401497 - Give menu-badged.svg context-fill-opacity Consistency, taking it. Should be in 57b3
Attachment #8911182 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: