Closed Bug 1401515 Opened 7 years ago Closed 7 years ago

Fix "member call on null pointer of type" errors from UBSan

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: anba, Assigned: anba)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

bug1401515.patch
2.69 KB, patch
luke
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch bug1401515.patch — — Splinter Review 
The |PropertyName* n| argument can be a null pointer, so let's just move the assertion after the test that |n| is not a null pointer. 

The other remaining member access on null pointer error when running jstests/jit-tests with UBSan was in JSScript::sizeOfTypeScript, so I folded that fix into this patch as well.
Attachment #8910235 - Flags: review?(luke)
Comment on attachment 8910235 [details] [diff] [review]
bug1401515.patch

Review of attachment 8910235 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8910235 - Flags: review?(luke) → review+
Priority: -- → P3
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02a2f71d54a1
Avoid accessing members on null pointers. r=luke
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/02a2f71d54a1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
We can probably let this rides the trains.
status-firefox57: affected → wontfix
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: