1401527 - Remove strings for recent bookmarks and/or pocket items in bookmarks menu(s)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, enhancement)

Description

[:Gijs (he/him)]

bug 1401238 removed the recent bookmarks and 'view pocket list' items, but left the strings in case we change our mind. If we don't, we should remove the strings at the end of the 58 cycle / beginning of the 59 cycle.

Comment 1

[Mark Banner (:standard8)]

Gijs, is it safe to do this now, or is there someone we should check in with?

Comment 2

[:Gijs (he/him)]

(In reply to Mark Banner (:standard8) from comment #1)
> Gijs, is it safe to do this now, or is there someone we should check in with?

No, this is safe. Both strings may be used elsewhere now, would be good to doublecheck, of course.

Comment 3

[Mark Banner (:standard8)]

Of the strings that I can find in code removals in bug 1401238, still used:

- recentBookmarks.label (https://searchfox.org/mozilla-central/search?q=recentBookmarks.label&case=false&regexp=false&path=)
- pocketMenuitem.label (https://searchfox.org/mozilla-central/search?q=pocketMenuitem.label&case=false&regexp=false&path=)

now unused:

- hideRecentlyBookmarked.label/accesskey (https://searchfox.org/mozilla-central/search?q=hideRecentlyBookmarked.&case=false&regexp=false&path=)
- showRecentlyBookmarked.label/accesskey (https://searchfox.org/mozilla-central/search?q=showRecentlyBookmarked.&case=false&regexp=false&path=)

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1401527 - Remove unused 'Recently Bookmarked' strings.

Follow-up to bug 1401238.

Review commit: https://reviewboard.mozilla.org/r/220136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/220136/

Comment 5

[:Gijs (he/him)]

Comment on attachment 8950882 [details]
Bug 1401527 - Remove unused 'Recently Bookmarked' strings.

https://reviewboard.mozilla.org/r/220136/#review226010

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00bb6658c45a
Remove unused 'Recently Bookmarked' strings. r=Gijs

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/00bb6658c45a