Closed Bug 1401549 Opened 5 years ago Closed 5 years ago

Disable Buildbot Windows Spidermonkey jobs

Categories

(Infrastructure & Operations Graveyard :: CIDuty, task, P2)

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Callek, Assigned: aselagea)

References

Details

Attachments

(2 files)

Once https://bugzilla.mozilla.org/show_bug.cgi?id=1401546 lands, we'll need to disable Buildbot Spidermonkey from branches where that code lives.

Specifically m-c/beta 57 (or maybe just m-c 58 if it lands after the ver bump)

We could either disable on try or leave enabled on try for --buildbot users of older trees, I'm not strongly for one way or the other here (:sfink may have an opinion, I'll n-i him for that answer)
Priority: -- → P2
Assignee: nobody → aselagea
(In reply to Justin Wood (:Callek) from comment #0)
> Once https://bugzilla.mozilla.org/show_bug.cgi?id=1401546 lands, we'll need
> to disable Buildbot Spidermonkey from branches where that code lives.
> 
> Specifically m-c/beta 57 (or maybe just m-c 58 if it lands after the ver
> bump)

So do we want to disable these Windows builds for all trunk branches (aka gecko >=58)?

> We could either disable on try or leave enabled on try for --buildbot users
> of older trees, I'm not strongly for one way or the other here (:sfink may
> have an opinion, I'll n-i him for that answer)

I don't see any buildbot Windows Spidermonkey builders running on try atm, so I think the answer is simple in this case :)
Flags: needinfo?(bugspam.Callek)
(In reply to Alin Selagea [:aselagea][:buildduty] from comment #1)
> (In reply to Justin Wood (:Callek) from comment #0)
> > Once https://bugzilla.mozilla.org/show_bug.cgi?id=1401546 lands, we'll need
> > to disable Buildbot Spidermonkey from branches where that code lives.
> > 
> > Specifically m-c/beta 57 (or maybe just m-c 58 if it lands after the ver
> > bump)
> 
> So do we want to disable these Windows builds for all trunk branches (aka
> gecko >=58)?

We actually want to disable them on gecko >=57, since my patch to enable them as tier 1 made 57's ride to beta.

> > We could either disable on try or leave enabled on try for --buildbot users
> > of older trees, I'm not strongly for one way or the other here (:sfink may
> > have an opinion, I'll n-i him for that answer)
> 
> I don't see any buildbot Windows Spidermonkey builders running on try atm,
> so I think the answer is simple in this case :)

Allthethings.json shows it in both try schedulers and try builders, and we have https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/config.py#1810 which explicitly mentions it.
Flags: needinfo?(bugspam.Callek)
Steve, can you please see c#0 here, I meant to n-i you when I filed this.
Flags: needinfo?(sphink)
kill them with fire
Flags: needinfo?(sphink)
Attached patch bug1401549.patchSplinter Review
Attachment #8914287 - Flags: review?(bugspam.Callek)
Attached file bld_diff.txt
Attachment #8914287 - Flags: review?(bugspam.Callek) → review+
Just needed to cleanup jobs which were pending/scheduled after this landed. Could you please check for leftover jobs an hour or two after removing builders.
(In reply to Nick Thomas [:nthomas] from comment #7)
> Just needed to cleanup jobs which were pending/scheduled after this landed.
> Could you please check for leftover jobs an hour or two after removing
> builders.

I don't think these pending jobs have anything to do with my patch. I double-checked on a test master before submitting it for review and there were no dependent tests.
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Product: Release Engineering → Infrastructure & Operations
Product: Infrastructure & Operations → Infrastructure & Operations Graveyard
You need to log in before you can comment on or make changes to this bug.