1401549 - Disable Buildbot Windows Spidermonkey jobs

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task, P2)

Description

[Justin Wood (:Callek)]

Once https://bugzilla.mozilla.org/show_bug.cgi?id=1401546 lands, we'll need to disable Buildbot Spidermonkey from branches where that code lives.

Specifically m-c/beta 57 (or maybe just m-c 58 if it lands after the ver bump)

We could either disable on try or leave enabled on try for --buildbot users of older trees, I'm not strongly for one way or the other here (:sfink may have an opinion, I'll n-i him for that answer)

Comment 1

[Alin Selagea [:aselagea]]

(In reply to Justin Wood (:Callek) from comment #0)
> Once https://bugzilla.mozilla.org/show_bug.cgi?id=1401546 lands, we'll need
> to disable Buildbot Spidermonkey from branches where that code lives.
> 
> Specifically m-c/beta 57 (or maybe just m-c 58 if it lands after the ver
> bump)

So do we want to disable these Windows builds for all trunk branches (aka gecko >=58)?

> We could either disable on try or leave enabled on try for --buildbot users
> of older trees, I'm not strongly for one way or the other here (:sfink may
> have an opinion, I'll n-i him for that answer)

I don't see any buildbot Windows Spidermonkey builders running on try atm, so I think the answer is simple in this case :)

Comment 2

[Justin Wood (:Callek)]

(In reply to Alin Selagea [:aselagea][:buildduty] from comment #1)
> (In reply to Justin Wood (:Callek) from comment #0)
> > Once https://bugzilla.mozilla.org/show_bug.cgi?id=1401546 lands, we'll need
> > to disable Buildbot Spidermonkey from branches where that code lives.
> > 
> > Specifically m-c/beta 57 (or maybe just m-c 58 if it lands after the ver
> > bump)
> 
> So do we want to disable these Windows builds for all trunk branches (aka
> gecko >=58)?

We actually want to disable them on gecko >=57, since my patch to enable them as tier 1 made 57's ride to beta.

> > We could either disable on try or leave enabled on try for --buildbot users
> > of older trees, I'm not strongly for one way or the other here (:sfink may
> > have an opinion, I'll n-i him for that answer)
> 
> I don't see any buildbot Windows Spidermonkey builders running on try atm,
> so I think the answer is simple in this case :)

Allthethings.json shows it in both try schedulers and try builders, and we have https://dxr.mozilla.org/build-central/source/buildbot-configs/mozilla/config.py#1810 which explicitly mentions it.

Comment 3

[Justin Wood (:Callek)]

Steve, can you please see c#0 here, I meant to n-i you when I filed this.

Comment 4

[Steve Fink [:sfink] [:s:]]

kill them with fire

Comment 5

[Alin Selagea [:aselagea]]

Attachment: bug1401549.patch

Comment 6

[Alin Selagea [:aselagea]]

Attachment: bld_diff.txt

Comment 7

[Nick Thomas [:nthomas] (UTC+12)]

Just needed to cleanup jobs which were pending/scheduled after this landed. Could you please check for leftover jobs an hour or two after removing builders.

Comment 8

[Alin Selagea [:aselagea]]

(In reply to Nick Thomas [:nthomas] from comment #7)
> Just needed to cleanup jobs which were pending/scheduled after this landed.
> Could you please check for leftover jobs an hour or two after removing
> builders.

I don't think these pending jobs have anything to do with my patch. I double-checked on a test master before submitting it for review and there were no dependent tests.

Comment 9

[Alin Selagea [:aselagea]]

Comment on attachment 8914287 [details] [diff] [review]
bug1401549.patch

https://hg.mozilla.org/build/buildbot-configs/rev/b3c3ba5ea2e9
https://hg.mozilla.org/build/buildbot-configs/rev/5af72c62a6a9