1401590 - undetected failure in services/fxaccounts/tests/xpcshell/test_push_service.js

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Kai Engert (:KaiE:)]

The tests executed by 
  services/fxaccounts/tests/xpcshell/test_push_service.js
are apparently failing, but the failures are ignored, and the test is reported as being successful.

Is it a bug that the failure are undetected and ignored?


FirefoxAccounts     TRACE        finished write of json user data - took: 84"

"JavaScript error: file:///Users/florian/buildhg/mozilla/obj-browser/dist/Nightly.app/Contents/Resources/components/storage-json.js, line 89: Error: Initialization failed"

"JavaScript error: file:///Users/florian/buildhg/mozilla/obj-browser/dist/Nightly.app/Contents/Resources/components/nsLoginManager.js, line 129: NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS: [JavaScript Error: "Initialization failed" {file: "file:///Users/florian/buildhg/mozilla/obj-browser/dist/Nightly.app/Contents/Resources/components/storage-json.js" line: 89}]'[JavaScript Error: "Initialization failed" {file: "file:///Users/florian/buildhg/mozilla/obj-browser/dist/Nightly.app/Contents/Resources/components/storage-json.js" line: 89}]' when calling method: [nsILoginManagerStorage::initialize]"

FirefoxAccounts     ERROR        Failed to clear login data: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: resource://gre/modules/XPCOMUtils.jsm :: XPCU_serviceLambda :: line 266"  data: no] Stack trace: XPCU_serviceLambda()@resource://gre/modules/XPCOMUtils.jsm:266 < get()@resource://gre/modules/XPCOMUtils.jsm:199 < _clearLoginMgrData()@resource://gre/modules/FxAccountsStorage.jsm:495"

FirefoxAccounts     ERROR        Failed to clear login data: [Exception... "Component returned failure code: 0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE) [nsIJSCID.getService]"  nsresult: "0x80570016 (NS_ERROR_XPC_GS_RETURNED_FAILURE)"  location: "JS frame :: resource://gre/modules/XPCOMUtils.jsm :: XPCU_serviceLambda :: line 266"  data: no] Stack trace: XPCU_serviceLambda()@resource://gre/modules/XPCOMUtils.jsm:266 < get()@resource://gre/modules/XPCOMUtils.jsm:199 < _clearLoginMgrData()@resource://gre/modules/FxAccountsStorage.jsm:495"

FirefoxAccounts     INFO not removing credentials from login manager - not logged in"
FirefoxAccounts     TRACE        storage set finished clearing account data"
FirefoxAccounts     DEBUG        account data reset"
FirefoxAccounts     TRACE        StorageManager finalizing"
FirefoxAccounts     TRACE        StorageManager finalized"
FirefoxAccounts     TRACE        initializing new storage manager"
FirefoxAccounts     TRACE        starting fetch of json user data"
FirefoxAccounts     TRACE        finished fetch of json user data - took: 1"
FirefoxAccounts     TRACE        initializing of new storage manager done"
FirefoxAccounts     DEBUG        Notifying observers of fxaccounts:onlogout"

Followed by several times:

"JavaScript error: /Users/florian/buildhg/mozilla/obj-browser/_tests/xpcshell/services/fxaccounts/tests/xpcshell/test_push_service.js -> resource://gre/components/FxAccountsPush.js, line 146: TypeError: Promise is undefined"

Comment 1

[Kai Engert (:KaiE:)]

Attachment: 1401590-info.patch

Using this patch, I was able to get better failure output.

Error: Initialization failed: Error: Phase "profile-before-change" is finished, it is too late to register completion condition "JSON store: writing data"

Comment 2

[Mark Hammond [:markh] [:mhammond]]

Ed, can you please take a look at this when you have a few spare cycles?

Comment 3

[Edouard Oger [:eoger]]

Attachment: Bug 1401590 - Mock FxAccounts#newAccountState in push service tests.

Review commit: https://reviewboard.mozilla.org/r/182346/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182346/

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8910862 [details]
Bug 1401590 - Mock FxAccounts#newAccountState in push service tests.

https://reviewboard.mozilla.org/r/182346/#review187752

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/97282b0c985a
Mock FxAccounts#newAccountState in push service tests. r=markh

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/97282b0c985a

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Is that we we would like to uplift to 57 to avoid these errors? Thanks

Comment 8

[Edouard Oger [:eoger]]

I don't think so, these are only tests related fixes.